-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
experimental flag to run Jenkins without YUI #9489
Conversation
The YUI library is old and no longer maintained. Add a user experimental flag to disable YUI. It's disabled by default. When enabling all the YUI related js libraries and css classes are not loaded. Following PR are required to get Jenkins to not show any errors eventually jenkinsci#7569 Some plugins that use YUI (not complete): credentials ldap global-build-stats build-monitor categorized-view Plugins that make use of makeButton (not complete) credentials (fixed with jenkinsci/credentials-plugin#533) openid acceptance-test-harness
core/src/main/java/jenkins/model/experimentalflags/RemoveYuiUserExperimentalFlag.java
Outdated
Show resolved
Hide resolved
Looks good to me! Thanks for compiling that list. |
Co-authored-by: Jan Faracik <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/label ready-for-merge
This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.
Thanks!
core/src/main/java/jenkins/model/experimentalflags/RemoveYuiUserExperimentalFlag.java
Show resolved
Hide resolved
core/src/main/java/jenkins/model/experimentalflags/RemoveYuiUserExperimentalFlag.java
Show resolved
Hide resolved
Add matrix-auth and azure-ad to the list due to their use of |
I've collected all usages of YUI here: |
The YUI library is old and no longer maintained.
Add a user experimental flag to disable YUI. The flag is disabled by default. When enabling the flag, all the YUI related js libraries and css classes are not loaded.
Following PR are required to get Jenkins to not show any errors
#9488
#9453
#7569
Some plugins that use YUI (not complete):
credentials
ldap
global-build-stats
build-monitor
categorized-view
matrix-project
Plugins that make use of makeButton (not complete)
credentials (fixed with jenkinsci/credentials-plugin#533)
openid
acceptance-test-harness
Testing done
Proposed changelog entries
Add a user experimental flag to run Jenkins without the YUI JavaScript library. Plugin authors should enable this flag and fix any issues that result from the removal of the YUI library.
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist