-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scroll fields from added hetero-list entry into viewport #9488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace usage of YUI with plain javascript in the ensureVisible method The current logic seems to have no effect, so it is changed in the following When the element is bigger then the current viewport height, scroll so that the element is at the top. If the elements is smaller than the viewport height and the bottom is outside scoll so that the bottom is at the lower end of the viewport. Otherwise no scrolling is needed the element is already completely inside the viewport.
timja
added
needs-ath-build
Needs to run through the full acceptance-test-harness suite
rfe
For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
web-ui
The PR includes WebUI changes which may need special expertise
labels
Jul 21, 2024
@mawinter69 you able to run an ATH build please? It can be sensitive to this sort of thing |
zbynek
reviewed
Jul 21, 2024
6 tasks
I've run ath here: jenkinsci/acceptance-test-harness#1628 without problems |
timja
added
ath-successful
This PR has successfully passed the full acceptance-test-harness suite
and removed
needs-ath-build
Needs to run through the full acceptance-test-harness suite
labels
Jul 23, 2024
timja
approved these changes
Jul 23, 2024
NotMyFault
approved these changes
Jul 25, 2024
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
comment-ops-bot
bot
added
the
ready-for-merge
The PR is ready to go, and it will be merged soon if there is no negative feedback
label
Jul 25, 2024
zbynek
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ath-successful
This PR has successfully passed the full acceptance-test-harness suite
ready-for-merge
The PR is ready to go, and it will be merged soon if there is no negative feedback
rfe
For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
web-ui
The PR includes WebUI changes which may need special expertise
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic in ensureVisible seems to have no effect, so it is changed in the following way:
This also replaces usage of YUI with plain javascript in the ensureVisible method
Bildschirmaufnahme.2024-07-20.141757.mp4
Bildschirmaufnahme.2024-07-20.141607.mp4
Bildschirmaufnahme.2024-07-20.141649.mp4
Testing done
Manual testing
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist