Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-72679] Don't animate admin monitor popup on page load, properly remove interactable UI elements #8954

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented Feb 12, 2024

PR #8941 caused a regression that the hiding animation was played on page load.
This change ensures that the hiding animation is only applied when the widget was visible before

Closes #8956

Testing done

Manually tested that the hiding animation is no longer shown on page load

Proposed changelog entries

  • Don't animate admin monitor on page load. Fixes a regression from 2.445.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

PR jenkinsci#8941 caused a regression that the hiding animation was played on
page load.
This change ensures that the hiding animation is only applied when the
widget was visible before
@NotMyFault NotMyFault added the skip-changelog Should not be shown in the changelog label Feb 12, 2024
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust the skip-changelogel label if the PR doesn't make it in tomorrow's release.

@daniel-beck
Copy link
Member

The animation is now gone, but note #8941 (comment).

Time to revert #8791?

@mawinter69
Copy link
Contributor Author

pushed a change that should avoid that there are still clickable artifacts. Basically the div is scaled to 0 when not visible

Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work now in some limited testing.

@daniel-beck daniel-beck changed the title don't animate admin monitor on page load Don't animate admin monitor popup on page load, properly remove interactable UI elements Feb 13, 2024
@NotMyFault NotMyFault added regression-fix Pull request that fixes a regression in one of the previous Jenkins releases and removed skip-changelog Should not be shown in the changelog labels Feb 13, 2024
@NotMyFault NotMyFault merged commit e5fd912 into jenkinsci:master Feb 13, 2024
17 checks passed
NotMyFault pushed a commit to NotMyFault/jenkins that referenced this pull request Feb 13, 2024
…actable UI elements (jenkinsci#8954)

* followup for jenkinsci#8941, don't animate on page load

PR jenkinsci#8941 caused a regression that the hiding animation was played on
page load.
This change ensures that the hiding animation is only applied when the
widget was visible before

* scale to 0

(cherry picked from commit e5fd912)
@daniel-beck daniel-beck changed the title Don't animate admin monitor popup on page load, properly remove interactable UI elements [JENKINS-72679] Don't animate admin monitor popup on page load, properly remove interactable UI elements Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-fix Pull request that fixes a regression in one of the previous Jenkins releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants