-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-72679] Don't animate admin monitor popup on page load, properly remove interactable UI elements #8954
Conversation
PR jenkinsci#8941 caused a regression that the hiding animation was played on page load. This change ensures that the hiding animation is only applied when the widget was visible before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please adjust the skip-changelogel
label if the PR doesn't make it in tomorrow's release.
The animation is now gone, but note #8941 (comment). Time to revert #8791? |
pushed a change that should avoid that there are still clickable artifacts. Basically the div is scaled to 0 when not visible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work now in some limited testing.
…actable UI elements (jenkinsci#8954) * followup for jenkinsci#8941, don't animate on page load PR jenkinsci#8941 caused a regression that the hiding animation was played on page load. This change ensures that the hiding animation is only applied when the widget was visible before * scale to 0 (cherry picked from commit e5fd912)
PR #8941 caused a regression that the hiding animation was played on page load.
This change ensures that the hiding animation is only applied when the widget was visible before
Closes #8956
Testing done
Manually tested that the hiding animation is no longer shown on page load
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist