Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update appearance of controls in header #8791

Merged
merged 7 commits into from
Jan 3, 2024

Conversation

janfaracik
Copy link
Contributor

  • Uses the item mixin for header links, this provides consistent rounding/hover/focus states
  • Use variables for colours, remove old hardcoded colours
  • Refined the appearance and animations of the warning links/dropdowns to be inline with modern dropdowns

Before
image

After
image

Testing done

  • Links works as before

Proposed changelog entries

  • Update appearance of controls in header

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@NotMyFault NotMyFault requested a review from a team December 22, 2023 20:52
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jan 2, 2024
@timja timja added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Jan 2, 2024
@NotMyFault NotMyFault merged commit d75833e into jenkinsci:master Jan 3, 2024
17 checks passed
@timja timja deleted the update-header-appearance branch January 3, 2024 22:24
@mawinter69
Copy link
Contributor

mawinter69 commented Feb 6, 2024

That change caused a regression.
How to reproduce:

  1. Have some admin warnings
  2. Go to /computer
  3. Click to show the admin monitors
  4. Click again to hide them

-> The buttons to add new Node and configure monitors are not working anymore as they are hidden behind the div with z-index 1000 and opacity: 0
That div should be hidden with display: none

@daniel-beck
Copy link
Member

@mawinter69 I filed that as JENKINS-72679 and linked #8941.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants