-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-72679] Allow button clicks after an administrative monitor popup is closed #8941
Conversation
The div of the admin monitor pop-up is set to opacity 0 but keeps z-index 1000 when closed. This makes the buttons, that are behind the popup when shown unusable. This change uses an animation that ensures the z-index is 0 after hiding the popup and buttons are still usable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/label ready-for-merge
This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.
Thanks!
With this change, the hiding animation plays when the page is initially showing (with an empty popup, a fairly small square). PR-8941-regression.movEnough to revert, or follow up separately? |
I'll provide a fix |
PR jenkinsci#8941 caused a regression that the hiding animation was played on page load. This change ensures that the hiding animation is only applied when the widget was visible before
This change does not properly remove the admin monitor UI elements, still resulting in unintentional interactions with the admin monitors (discovered and recorded with the #8954 PR build, but it's also in here).
|
…ble (jenkinsci#8941)" This reverts commit a642354.
…kinsci#8941) avoid admin monitor makes buttons unusable The div of the admin monitor pop-up is set to opacity 0 but keeps z-index 1000 when closed. This makes the buttons, that are behind the popup when shown unusable. This change uses an animation that ensures the z-index is 0 after hiding the popup and buttons are still usable (cherry picked from commit a642354)
…actable UI elements (jenkinsci#8954) * followup for jenkinsci#8941, don't animate on page load PR jenkinsci#8941 caused a regression that the hiding animation was played on page load. This change ensures that the hiding animation is only applied when the widget was visible before * scale to 0 (cherry picked from commit e5fd912)
The div of the admin monitor pop-up is set to opacity 0 but keeps z-index 1000 when closed. This makes the buttons, that are behind the popup when shown unusable.
This change uses an animation that ensures the z-index is 0 after hiding the popup and buttons are still usable
Before:
Broken.mp4
After:
fixed.mp4
Testing done
Manually testing
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
N/A
Before the changes are marked as
ready-for-merge
:Maintainer checklist