Use spotbugs 4.8.2 with more exclusions

[MarkEWaite]

Use spotbugs plugin 4.8.2.0 with additional suppressions

The parent pom spotbugs pull request needs this change along with the changes in other repositories that use the Jenkins parent pom.

jenkinsci/pom#501 (review) recommends that the new spotbugs issues be either suppressed or resolved in the upstream release of spotbugs. This change suppresses the new warning for primitive fields that are publicly visible and the new warning for a few cases where a field could be made static.

This change skips the warnings related to CT_CONSTRUCTOR_THROWS because they are not relevant to Jenkins. jenkinsci/plugin-pom#869 (comment) provides more details along with the discussion at spotbugs/spotbugs#2695

The changes to pom.xml are flagged so that they can be removed when the other repositories that consume the parent pom have been verified that they will be able to use spotbugs plugin 4.8.2.0 without additional noise.

Additional pull requests that have been merged include:

• Use spotbugs 4.8.2 with more exclusions lib-file-leak-detector#164
• Use spotbugs 4.8.2 with more exclusions remoting#708
• Use spotbugs 4.8.2 with more exclusions stapler#507

The additional repositories that have been reviewed and confirmed they are ready for the parent pom update to use spotbugs 4.8.2 include:

• https://github.com/jenkinsci/acceptance-test-harness
• https://github.com/jenkinsci/bom
• https://github.com/jenkinsci/bridge-method-injector
• https://github.com/jenkinsci/extensibility-api
• https://github.com/jenkinsci/extras-memory-monitor
• https://github.com/jenkinsci/jellydoc-maven-plugin
• https://github.com/jenkinsci/jelly
• https://github.com/jenkinsci/jenkins-test-harness-htmlunit
• https://github.com/jenkinsci/jenkins-test-harness
• https://github.com/jenkinsci/lib-access-modifier
• https://github.com/jenkinsci/lib-annotation-indexer
• https://github.com/jenkinsci/lib-crypto-util
• https://github.com/jenkinsci/lib-mock-javamail
• https://github.com/jenkinsci/lib-process-utils
• https://github.com/jenkinsci/lib-support-log-formatter
• https://github.com/jenkinsci/lib-symbol-annotation
• https://github.com/jenkinsci/lib-task-reactor
• https://github.com/jenkinsci/lib-test-annotations
• https://github.com/jenkinsci/lib-version-number
• https://github.com/jenkinsci/maven-hpi-plugin
• https://github.com/jenkinsci/plugin-compat-tester
• https://github.com/jenkinsci/plugin-installation-manager-tool
• https://github.com/jenkinsci/stapler-maven-plugin
• https://github.com/jenkinsci/trilead-ssh2
• https://github.com/jenkinsci/winp
• https://github.com/jenkinsci/winstone

Testing done

Confirmed that automated tests pass on my Linux computer with Java 21.

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Beta Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests.
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Before the changes are marked as ready-for-merge:

Maintainer checklist

Beta Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).