Skip to content

Commit

Permalink
Suppress new warnings for spotbugs 4.8.2 (#164)
Browse files Browse the repository at this point in the history
Prep for

* jenkinsci/pom#510

Part of the checklist in:

* jenkinsci/jenkins#8803

Needs to be merged on or before the update of the parent pom that
updates to use spotbugs 4.8.2.
  • Loading branch information
MarkEWaite authored Dec 25, 2023
1 parent 2ae84b4 commit 8001149
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 4 deletions.
4 changes: 4 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@
<changelist>-SNAPSHOT</changelist>
<gitHubRepo>jenkinsci/lib-${project.artifactId}</gitHubRepo>
<asm.version>9.6</asm.version>
<!-- TODO: Remove when parent pom is using this version or newer -->
<!-- https://github.com/jenkinsci/pom/pull/510 -->
<spotbugs-maven-plugin.version>4.8.2.0</spotbugs-maven-plugin.version>
<spotbugs.omitVisitors>FindReturnRef,ConstructorThrow</spotbugs.omitVisitors>
</properties>

<dependencies>
Expand Down
12 changes: 8 additions & 4 deletions src/spotbugs/excludesFilter.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,14 @@
Exclusions in this section have been triaged and determined to be false positives.
-->
<Match>
<Or>
<!-- Pending https://github.com/spotbugs/spotbugs/issues/1515 -->
<Bug pattern="DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED"/>
</Or>
<!-- Pending https://github.com/spotbugs/spotbugs/issues/1515 -->
<Bug pattern="DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED"/>
</Match>
<Match>
<!-- Preserve API compatibility -->
<Bug pattern="PA_PUBLIC_PRIMITIVE_ATTRIBUTE"/>
<Class name="org.kohsuke.file_leak_detector.Listener"/>
<Field name="THRESHOLD"/>
</Match>
<!--
Here lies technical debt. Exclusions in this section have not yet been triaged. When working on
Expand Down

0 comments on commit 8001149

Please sign in to comment.