Summary: Use spotbugs 4.8.2 with more exclusions

Prep for * jenkinsci/pom#510 Part of the checklist in: * jenkinsci/jenkins#8803
MarkEWaite · Dec 25, 2023 · beada6d · beada6d
1 parent 063b3dd
commit beada6d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/core/src/main/java/org/kohsuke/stapler/TokenList.java b/core/src/main/java/org/kohsuke/stapler/TokenList.java
@@ -23,6 +23,7 @@
 
 package org.kohsuke.stapler;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.StringTokenizer;
 import java.io.ByteArrayOutputStream;
 import java.nio.charset.StandardCharsets;
@@ -46,6 +47,7 @@ public final class TokenList {
     /**
      * Index of the next token.
      */
+    @SuppressFBWarnings(value="PA_PUBLIC_PRIMITIVE_ATTRIBUTE", justification="Preserve API compatibility")
     public int idx;
 
     /**

diff --git a/core/src/main/java/org/kohsuke/stapler/export/ExportConfig.java b/core/src/main/java/org/kohsuke/stapler/export/ExportConfig.java
@@ -1,5 +1,7 @@
 package org.kohsuke.stapler.export;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+
 /**
  * Controls the output behaviour.
  *
@@ -11,6 +13,7 @@ public class ExportConfig {
      *      Use getter and setter
      */
     @Deprecated
+    @SuppressFBWarnings(value="PA_PUBLIC_PRIMITIVE_ATTRIBUTE", justification="Preserve API compatibility")
     public boolean prettyPrint;
 
     private ClassAttributeBehaviour classAttribute = ClassAttributeBehaviour.IF_NEEDED;

diff --git a/pom.xml b/pom.xml
@@ -46,6 +46,10 @@
     <scmTag>HEAD</scmTag>
     <jetty.version>10.0.18</jetty.version>
     <gitHubRepo>jenkinsci/stapler</gitHubRepo>
+    <!-- TODO: Remove when parent pom is using this version or newer -->
+    <!-- https://github.com/jenkinsci/pom/pull/510 -->
+    <spotbugs-maven-plugin.version>4.8.2.0</spotbugs-maven-plugin.version>
+    <spotbugs.omitVisitors>FindReturnRef,ConstructorThrow</spotbugs.omitVisitors>    
   </properties>
 
   <dependencyManagement>