JEP draft: WebSocket Services #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 22, 2019
[JEP-222] - Add WebSocket support when running Jenkins test rules
jenkinsci/jenkins-test-harness#183
Merged
rtyler
approved these changes
Nov 22, 2019
There was a problem hiding this comment.
From my perspective this a well structured JEP, great work @jglick! I would like one other person to weigh in, but if they do not before the beginning of December, I'll go ahead and number this (assuming no specific range requested), .
slide
reviewed
Nov 25, 2019
slide
approved these changes
Nov 25, 2019
omehegan
approved these changes
Nov 25, 2019
rsandell
approved these changes
Nov 26, 2019
oleg-nenashev
approved these changes
Nov 26, 2019
jeffret-b
approved these changes
Nov 26, 2019
There was a problem hiding this comment.
This is great. It explains things well and provides useful information. The approach makes a lot of sense. I like how it fits into the existing infrastructure. This will be a great addition to the existing infrastructure mechanisms.
I haven't yet looked at the implementation PRs, but I'll glance over them now and plan on more thorough reviews later.
|
@rtyler I guess this can be merged & numbered now? |
|
I might get to merging it next week after DWJW
…On Mon, Dec 2, 2019, 18:10 Jesse Glick ***@***.***> wrote:
@rtyler <https://github.com/rtyler> I guess this can be merged & numbered
now?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#250?email_source=notifications&email_token=AAW4RIDXAXABBZWATDHBT2DQWVFP3A5CNFSM4JQWBZHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFUL7IA#issuecomment-560512928>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAW4RICR3HDENEL4CPSJF23QWVFP3ANCNFSM4JQWBZHA>
.
|
…ck to zeeëend) Co-Authored-By: Jeff Thompson <[email protected]>
|
@oleg-nenashev No reason to wait. |
|
No reason, just a bandwidth issue
…On Wed, Dec 4, 2019, 09:56 Liam Newman ***@***.***> wrote:
Merged #250 <#250> into master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#250?email_source=notifications&email_token=AAW4RIHU5HHD4KTGUX2SZETQW55E3A5CNFSM4JQWBZHKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVIJHJUA#event-2853336272>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAW4RIGYD5I5GVQA6UWYXGLQW55E3ANCNFSM4JQWBZHA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prototype implementation in jenkinsci/jenkins#4369 and its upstreams.