Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog post & documentation updates about WebSocket #2807

Merged
merged 8 commits into from
Feb 2, 2020

Conversation

jglick
Copy link
Contributor

@jglick jglick commented Jan 27, 2020

jenkinsci/jenkins#4369 (comment) by @oleg-nenashev.

Also seems like a good place to update the weekly changelog and existing reference documentation to note the new option.

@jglick jglick requested a review from a team as a code owner January 27, 2020 19:24
@jglick jglick changed the title Blog post about WebSocket Blog post & documentation updates about WebSocket Jan 27, 2020
Copy link
Contributor

@richbg richbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -5925,6 +5925,8 @@
references:
- url: https://github.com/jenkinsci/jep/blob/master/jep/222/README.adoc
title: JEP-222
- url: /blog/2020/01/27/web-socket/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since no one seems to be around today, feel free to update to the current date as well as renaming 2020-01-27-web-socket.adoc when actually publishing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm running my Chromebook from a hotel room currently and don't know the GitHub web UI technique to rename a file in a pull request. I propose that we accept this blog post date "as is" and publish today, 29 Jan 2020. Close enough to the actual date of publication for my concerns.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update the date for today.

@@ -5925,6 +5925,8 @@
references:
- url: https://github.com/jenkinsci/jep/blob/master/jep/222/README.adoc
title: JEP-222
- url: /blog/2020/01/27/web-socket/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm running my Chromebook from a hotel room currently and don't know the GitHub web UI technique to rename a file in a pull request. I propose that we accept this blog post date "as is" and publish today, 29 Jan 2020. Close enough to the actual date of publication for my concerns.

@oleg-nenashev
Copy link
Contributor

@MarkEWaite I will fix the date. I propose to publish it tomorrow after Docker inages are released

Copy link
Contributor

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explicitly specify the required agent versions. Currently the blogpost specifies only the mater version, but upgrading masters is not enough to activate the feature

I am putting it on hold until Jenkins agent Docker images are released. FTR jenkinsci/docker-agent#103 and jenkinsci/docker-inbound-agent#145 . Without it the websocket support is not complete.

@jglick
Copy link
Contributor Author

jglick commented Jan 29, 2020

explicitly specify the required agent versions

Good point, will do.

I am putting it on hold until Jenkins agent Docker images are released. … Without it the websocket support is not complete.

Well, true, but this seems a little extreme; this is just a blog post after all, and I can just mention that the Docker images are coming soon.

@jglick jglick requested a review from oleg-nenashev January 29, 2020 15:54
Copy link
Contributor

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing comments!
I am stuck with Docker images, so let's merge it as is.
I will do the announcements tomorrow or on Monday

@oleg-nenashev
Copy link
Contributor

Build is green, merging

@oleg-nenashev oleg-nenashev merged commit 33eb41b into jenkins-infra:master Feb 2, 2020
@jglick jglick deleted the blog branch February 3, 2020 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants