Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-41825] Display an informative message, rather than a Groovy exception, when View.getItems fails #2739

Merged
merged 1 commit into from
Feb 9, 2017
Merged

[JENKINS-41825] Display an informative message, rather than a Groovy exception, when View.getItems fails #2739

merged 1 commit into from
Feb 9, 2017

Conversation

jglick
Copy link
Member

@jglick jglick commented Feb 7, 2017

JENKINS-41825

@reviewbybees

@daniel-beck daniel-beck added the needs-more-reviews Complex change, which would benefit from more eyes label Feb 8, 2017
oleg-nenashev
oleg-nenashev approved these changes Feb 8, 2017
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐝

@jglick
Copy link
Member Author

jglick commented Feb 9, 2017

@reviewbybees done

@jglick jglick added ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback and removed needs-more-reviews Complex change, which would benefit from more eyes labels Feb 9, 2017
@daniel-beck daniel-beck merged commit ee4afc3 into jenkinsci:master Feb 9, 2017
@jglick jglick deleted the View.getItems-JENKINS-41825 branch February 10, 2017 15:46
daniel-beck added a commit that referenced this pull request Feb 13, 2017
@daniel-beck
Noting #2722 #2723 #2727 #2732 #2735 #2737 #2738 #2739 #2744
f6005c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-beck daniel-beck daniel-beck approved these changes

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jglick @daniel-beck @oleg-nenashev