[FIX JENKINS-41457] Use BUILD_NOW_TEXT for parameterised jobs #2735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Asking @jglick to take a look |
jglick
approved these changes
Feb 6, 2017
| String pageText = j.createWebClient().getPage(p).asText(); | ||
| assertThat(pageText, containsString("newschool:aaa")); | ||
|
|
||
| Impl.oldschool = true; |
There was a problem hiding this comment.
@jglick sorry but I don't know what the try-finally is for
| /** | ||
| * Makes sure that {@link AlternativeUiTextProvider} actually works with a parameterized Job. | ||
| */ | ||
| @Test |
daniel-beck
reviewed
Feb 7, 2017
| @@ -278,7 +278,8 @@ public static final CauseAction getBuildCause(ParameterizedJob job, StaplerReque | |||
| * Uses {@link #BUILD_NOW_TEXT}. | |||
| */ | |||
| public final String getBuildNowText() { | |||
| return isParameterized() ? Messages.ParameterizedJobMixIn_build_with_parameters() : AlternativeUiTextProvider.get(BUILD_NOW_TEXT, asJob(), Messages.ParameterizedJobMixIn_build_now()); | |||
| return isParameterized() ? AlternativeUiTextProvider.get(BUILD_NOW_TEXT, asJob(), Messages.ParameterizedJobMixIn_build_with_parameters()) | |||
There was a problem hiding this comment.
Shouldn't this rather have a new variant BUILD_WITH_PARAMETERS_TEXT? The difference IIUC is that "Build Now" indicates an immediate action, while the other does not (like when in many applications some actions have a trailing … and others don't).
There was a problem hiding this comment.
Not needed, BUILD_NOW_TEXT is the AlternativeUiTextProvider inside it you can check if the job has parameters and decide what text you want to display.
|
@reviewbybees done |
oleg-nenashev
added
the
ready-for-merge
jglick
approved these changes
Feb 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jenkins-ci.org/browse/JENKINS-41757
@reviewbybees @jenkinsci/code-reviewers