[JENKINS-16634] Do not fail to write a log file just because something deleted the parent directory #2738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mething deleted the parent directory.
jglick
commented
Feb 6, 2017
| @@ -772,6 +772,7 @@ THE SOFTWARE. | |||
| <forkCount>0.5C</forkCount> | |||
| <reuseForks>true</reuseForks> | |||
| <argLine>-XX:MaxPermSize=128m -noverify</argLine> <!-- some versions of JDK7/8 causes VerifyError during mock tests: http://code.google.com/p/powermock/issues/detail?id=504 --> | |||
| <trimStackTrace>false</trimStackTrace> <!-- SUREFIRE-1226 workaround --> | |||
There was a problem hiding this comment.
Otherwise the pre-fix test failure omits the interesting bits in its stack trace.
There was a problem hiding this comment.
Unrelated, but Ok. Woukd be better to have it in a separate PR
| * @author Kohsuke Kawaguchi | ||
| */ | ||
| public class ReopenableRotatingFileOutputStreamTest { | ||
| public class RewindableRotatingFileOutputStreamTest { |
There was a problem hiding this comment.
ReopenableRotatingFileOutputStream was deprecated in #2490 and SlaveComputer now uses RewindableRotatingFileOutputStream, so test that.
oleg-nenashev
approved these changes
Feb 6, 2017
| @@ -772,6 +772,7 @@ THE SOFTWARE. | |||
| <forkCount>0.5C</forkCount> | |||
| <reuseForks>true</reuseForks> | |||
| <argLine>-XX:MaxPermSize=128m -noverify</argLine> <!-- some versions of JDK7/8 causes VerifyError during mock tests: http://code.google.com/p/powermock/issues/detail?id=504 --> | |||
| <trimStackTrace>false</trimStackTrace> <!-- SUREFIRE-1226 workaround --> | |||
There was a problem hiding this comment.
Unrelated, but Ok. Woukd be better to have it in a separate PR
daniel-beck
approved these changes
Feb 7, 2017
jglick
added
the
ready-for-merge
|
@reviewbybees done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-16634
No one is sure why the directory is deleted, but refusing to connect an agent because of this is not graceful. Test reproduced a similar error.
@reviewbybees