Optimization for AbstractLazyLoadRunMap.loadNumberOnDisk (#8494)

jenkinsci · Sep 20, 2023 · e996d0c · e996d0c
1 parent c8874d0
commit e996d0c
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/core/src/main/java/jenkins/model/lazy/AbstractLazyLoadRunMap.java b/core/src/main/java/jenkins/model/lazy/AbstractLazyLoadRunMap.java
@@ -51,6 +51,7 @@
 import java.util.function.IntConsumer;
 import java.util.logging.Level;
 import java.util.logging.Logger;
+import java.util.regex.Pattern;
 import jenkins.util.MemoryReductionUtil;
 import org.kohsuke.accmod.Restricted;
 import org.kohsuke.accmod.restrictions.NoExternalUse;
@@ -332,6 +333,8 @@ public synchronized void purgeCache() {
         loadNumberOnDisk();
     }
 
+    private static final Pattern BUILD_NUMBER = Pattern.compile("[0-9]+");
+
     private void loadNumberOnDisk() {
         String[] kids = dir.list();
         if (kids == null) {
@@ -340,10 +343,14 @@ private void loadNumberOnDisk() {
         }
         SortedIntList list = new SortedIntList(kids.length / 2);
         for (String s : kids) {
+            if (!BUILD_NUMBER.matcher(s).matches()) {
+                // not a build directory
+                continue;
+            }
             try {
                 list.add(Integer.parseInt(s));
             } catch (NumberFormatException e) {
-                // this isn't a build dir
+                // matched BUILD_NUMBER but not an int?
             }
         }
         list.sort();