Optimization for AbstractLazyLoadRunMap.loadNumberOnDisk

[jglick]

Was looking at a thread dump with some performance issues and noticed

[email protected]/java.lang.Throwable.fillInStackTrace(Native Method)
[email protected]/java.lang.Throwable.fillInStackTrace(Throwable.java:787)
[email protected]/java.lang.Throwable.<init>(Throwable.java:270)
[email protected]/java.lang.Exception.<init>(Exception.java:66)
[email protected]/java.lang.RuntimeException.<init>(RuntimeException.java:62)
[email protected]/java.lang.IllegalArgumentException.<init>(IllegalArgumentException.java:52)
[email protected]/java.lang.NumberFormatException.<init>(NumberFormatException.java:55)
[email protected]/java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
[email protected]/java.lang.Integer.parseInt(Integer.java:638)
[email protected]/java.lang.Integer.parseInt(Integer.java:770)
jenkins.model.lazy.AbstractLazyLoadRunMap.loadNumberOnDisk(AbstractLazyLoadRunMap.java:344)

There are surely other things going on, but it occurred to me that it is wasteful to construct a stack trace (which can be relatively expensive) just to skip a directory entry which does not look like a number.

Testing done

None.

Proposed changelog entries

• Small speculative optimization in build loading.

Proposed upgrade guidelines

N/A

Before the changes are marked as ready-for-merge:

Maintainer checklist

Beta Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[daniel-beck]

Small speculative optimization in build loading.

skip-changelog?

[jglick]

Small speculative optimization in build loading.

skip-changelog?

No particular opinion either way.