Skip to content

Commit

Permalink
[JENKINS-71880] fix notification in breadcrumb (#8493)
Browse files Browse the repository at this point in the history
* [JENKINS-71880] fix notification in breadcrumb

fix the notification when e.g. triggering a build via the breadcrumb.

replace the hoverNotification with a notificationBar. When the
hoverNotification appears the actual menu disappears making the
notification somehow look misplaced.
Prepend the message with the actual menu entry to make it more clear
what the message means.

* run prettier
  • Loading branch information
mawinter69 authored Sep 20, 2023
1 parent 3e1747e commit c8874d0
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions war/src/main/js/components/dropdowns/jumplists.js
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,10 @@ function mapChildrenItemsToDropdownItems(items) {
method: "post",
headers: crumb.wrap({}),
});
if (event.length === 1 && event[0].target != null) {
hoverNotification("Done.", event[0].target);
}
notificationBar.show(
item.displayName + ": Done.",
notificationBar.SUCCESS,
);
}
}
},
Expand Down

0 comments on commit c8874d0

Please sign in to comment.