Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding prometheus \ metrics guidance per issue #23 #78

Closed
wants to merge 1 commit into from
Closed

Adding prometheus \ metrics guidance per issue #23 #78

wants to merge 1 commit into from

Conversation

holmesb
Copy link
Contributor

@holmesb holmesb commented Oct 5, 2020

No description provided.

@holmesb holmesb requested a review from a team as a code owner October 5, 2020 10:07
torstenwalter
torstenwalter requested changes Oct 5, 2020
View reviewed changes
charts/jenkins/README.md
@@ -517,6 +517,16 @@ master:
enabled: true # was false
```

## Prometheus Metrics
Copy link
Member

@torstenwalter torstenwalter Oct 5, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@holmesb Can you move this before ### HTTPS Keystore Configuration.
Here it would be part of the migration to version 2.0.0.

torstenwalter
torstenwalter reviewed Oct 9, 2020
View reviewed changes
charts/jenkins/CHANGELOG.md
@@ -10,6 +10,10 @@ Use the following links to reference issues, PRs, and commits prior to v2.6.0.

The change log until v1.5.7 was auto-generated based on git commits. Those entries include a reference to the git commit to be able to get more details.

## 2.8.2

Fix indentation of JAVA_OPTS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@holmesb I think this should be changed to "Added prometheus metric documentation."

@stale
Copy link

stale bot commented Nov 9, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 9, 2020
@torstenwalter torstenwalter mentioned this pull request Nov 21, 2020
Merged
2 tasks
torstenwalter referenced this pull request in torstenwalter/jenkins-helm-charts Nov 21, 2020
@torstenwalter @wmcdona89 @holmesb
Jenkins 3.0.0
c1b6807 
* Chart uses StatefulSet instead of Deployment
* XML configuration was dropped
* offending terms have been removed
* values have been renamed and re-ordered to make it easier to use
* already deprecated items got removed
* chart migrated to helm 3.0.0

List of contributions:

- Dylan Piergies: Replace Deployment with StatefulSet #33
- Aaron McDonald: move kubernetes plugin configuration under agent #106
- holmesb: Adding prometheus \ metrics guidance #78

Closes #78

Co-authored-by: Aaron McDonald <[email protected]>
Co-authored-by: Dylan Piergies [email protected]
Co-authored-by: holmesb <[email protected]>
Signed-off-by: Torsten Walter <[email protected]>
This was referenced Nov 21, 2020
Closed
Merged
@stale
Copy link

stale bot commented Nov 24, 2020

This issue is being automatically closed due to inactivity.

@stale stale bot closed this Nov 24, 2020
torstenwalter added a commit that referenced this pull request Nov 26, 2020
@torstenwalter @wmcdona89 @holmesb
Jenkins 3.0.0
55476e6 
* Chart uses StatefulSet instead of Deployment
* XML configuration was dropped
* offending terms have been removed
* values have been renamed and re-ordered to make it easier to use
* already deprecated items got removed
* chart migrated to helm 3.0.0
* rename containers (#155)
* Configure admin user via configuration as code (#158)
  * admin username and password are no longer exposed as environment
    variables
  * admin password is not modified on helm updates instead the values from
    the existing secret is re-used
  * default length of admin password was increased
  * renamed useSecurity to adminSecret as disabling
    security feels odd and it's not what this flag does.
  * Check usage of deprecated imageTag (#161)
  * Remove whitespace when not rendering helm.sh/chart label (#160)
    Before:

    ```
    kind: PersistentVolumeClaim
    apiVersion: v1
    metadata:
      name: RELEASE-NAME-jenkins
      namespace: cockpit
      labels:
        "app.kubernetes.io/name": 'jenkins'

        "app.kubernetes.io/managed-by": "Helm"
        "app.kubernetes.io/instance": "RELEASE-NAME"
        "app.kubernetes.io/component": "jenkins-controller"
    ```

    After:

    ```
    kind: PersistentVolumeClaim
    apiVersion: v1
    metadata:
      name: RELEASE-NAME-jenkins
      namespace: cockpit
      labels:
        "app.kubernetes.io/name": 'jenkins'
        "app.kubernetes.io/managed-by": "Helm"
        "app.kubernetes.io/instance": "RELEASE-NAME"
        "app.kubernetes.io/component": "jenkins-controller"
    ```

List of contributions:

- Dylan Piergies: Replace Deployment with StatefulSet #33
- Aaron McDonald: move kubernetes plugin configuration under agent #106
- holmesb: Adding prometheus \ metrics guidance #78
- Florian Buchmeier: Updated UI tests to use official BATS image since
  dduportal/bats:0.4.0 is still using docker manifest v1 and thus is deprecated. (#157)

Closes #78

Co-authored-by: Aaron McDonald <[email protected]>
Co-authored-by: Dylan Piergies [email protected]
Co-authored-by: holmesb <[email protected]>
Signed-off-by: Torsten Walter <[email protected]>
torstenwalter referenced this pull request in torstenwalter/jenkins-helm-charts Nov 26, 2020
@torstenwalter @wmcdona89 @holmesb
Jenkins 3.0.0
c11234a 
* Chart uses StatefulSet instead of Deployment
* XML configuration was dropped
* offending terms have been removed
* values have been renamed and re-ordered to make it easier to use
* already deprecated items got removed
* chart migrated to helm 3.0.0
* rename containers (#155)
* Configure admin user via configuration as code (#158)
  * admin username and password are no longer exposed as environment
    variables
  * admin password is not modified on helm updates instead the values from
    the existing secret is re-used
  * default length of admin password was increased
  * renamed useSecurity to adminSecret as disabling
    security feels odd and it's not what this flag does.
  * Check usage of deprecated imageTag (#161)
  * Remove whitespace when not rendering helm.sh/chart label (#160)
    Before:

    ```
    kind: PersistentVolumeClaim
    apiVersion: v1
    metadata:
      name: RELEASE-NAME-jenkins
      namespace: cockpit
      labels:
        "app.kubernetes.io/name": 'jenkins'

        "app.kubernetes.io/managed-by": "Helm"
        "app.kubernetes.io/instance": "RELEASE-NAME"
        "app.kubernetes.io/component": "jenkins-controller"
    ```

    After:

    ```
    kind: PersistentVolumeClaim
    apiVersion: v1
    metadata:
      name: RELEASE-NAME-jenkins
      namespace: cockpit
      labels:
        "app.kubernetes.io/name": 'jenkins'
        "app.kubernetes.io/managed-by": "Helm"
        "app.kubernetes.io/instance": "RELEASE-NAME"
        "app.kubernetes.io/component": "jenkins-controller"
    ```

List of contributions:

- Dylan Piergies: Replace Deployment with StatefulSet #33
- Aaron McDonald: move kubernetes plugin configuration under agent #106
- holmesb: Adding prometheus \ metrics guidance #78
- Florian Buchmeier: Updated UI tests to use official BATS image since
  dduportal/bats:0.4.0 is still using docker manifest v1 and thus is deprecated. (#157)

Closes #78

Co-authored-by: Aaron McDonald <[email protected]>
Co-authored-by: Dylan Piergies [email protected]
Co-authored-by: holmesb <[email protected]>
Signed-off-by: Torsten Walter <[email protected]>
torstenwalter added a commit that referenced this pull request Nov 26, 2020
@torstenwalter @wmcdona89 @holmesb
Jenkins 3.0.0 (#153)
c00b41a 
* Chart uses StatefulSet instead of Deployment
* XML configuration was dropped
* offending terms have been removed
* values have been renamed and re-ordered to make it easier to use
* already deprecated items got removed
* chart migrated to helm 3.0.0
* rename containers (#155)
* Configure admin user via configuration as code (#158)
  * admin username and password are no longer exposed as environment
    variables
  * admin password is not modified on helm updates instead the values from
    the existing secret is re-used
  * default length of admin password was increased
  * renamed useSecurity to adminSecret as disabling
    security feels odd and it's not what this flag does.
  * Check usage of deprecated imageTag (#161)
  * Remove whitespace when not rendering helm.sh/chart label (#160)
    Before:

    ```
    kind: PersistentVolumeClaim
    apiVersion: v1
    metadata:
      name: RELEASE-NAME-jenkins
      namespace: cockpit
      labels:
        "app.kubernetes.io/name": 'jenkins'

        "app.kubernetes.io/managed-by": "Helm"
        "app.kubernetes.io/instance": "RELEASE-NAME"
        "app.kubernetes.io/component": "jenkins-controller"
    ```

    After:

    ```
    kind: PersistentVolumeClaim
    apiVersion: v1
    metadata:
      name: RELEASE-NAME-jenkins
      namespace: cockpit
      labels:
        "app.kubernetes.io/name": 'jenkins'
        "app.kubernetes.io/managed-by": "Helm"
        "app.kubernetes.io/instance": "RELEASE-NAME"
        "app.kubernetes.io/component": "jenkins-controller"
    ```

List of contributions:

- Dylan Piergies: Replace Deployment with StatefulSet #33
- Aaron McDonald: move kubernetes plugin configuration under agent #106
- holmesb: Adding prometheus \ metrics guidance #78
- Florian Buchmeier: Updated UI tests to use official BATS image since
  dduportal/bats:0.4.0 is still using docker manifest v1 and thus is deprecated. (#157)

Closes #78

Co-authored-by: Aaron McDonald <[email protected]>
Co-authored-by: Dylan Piergies [email protected]
Co-authored-by: holmesb <[email protected]>
Signed-off-by: Torsten Walter <[email protected]>

Co-authored-by: Aaron McDonald <[email protected]>
Co-authored-by: holmesb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torstenwalter torstenwalter torstenwalter requested changes

Assignees
No one assigned
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holmesb @torstenwalter