Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check usage of deprecated imageTag #161

Merged

Conversation

torstenwalter
Copy link
Member

What this PR does / why we need it

Users would want a hint if they are using a value, which is no longer supported.

Checklist

@torstenwalter torstenwalter requested a review from a team as a code owner November 25, 2020 15:29
@torstenwalter torstenwalter merged commit 4b893df into jenkinsci:prepare-3-0-0 Nov 25, 2020
torstenwalter added a commit that referenced this pull request Nov 26, 2020
* Chart uses StatefulSet instead of Deployment
* XML configuration was dropped
* offending terms have been removed
* values have been renamed and re-ordered to make it easier to use
* already deprecated items got removed
* chart migrated to helm 3.0.0
* rename containers (#155)
* Configure admin user via configuration as code (#158)
  * admin username and password are no longer exposed as environment
    variables
  * admin password is not modified on helm updates instead the values from
    the existing secret is re-used
  * default length of admin password was increased
  * renamed useSecurity to adminSecret as disabling
    security feels odd and it's not what this flag does.
  * Check usage of deprecated imageTag (#161)
  * Remove whitespace when not rendering helm.sh/chart label (#160)
    Before:

    ```
    kind: PersistentVolumeClaim
    apiVersion: v1
    metadata:
      name: RELEASE-NAME-jenkins
      namespace: cockpit
      labels:
        "app.kubernetes.io/name": 'jenkins'

        "app.kubernetes.io/managed-by": "Helm"
        "app.kubernetes.io/instance": "RELEASE-NAME"
        "app.kubernetes.io/component": "jenkins-controller"
    ```

    After:

    ```
    kind: PersistentVolumeClaim
    apiVersion: v1
    metadata:
      name: RELEASE-NAME-jenkins
      namespace: cockpit
      labels:
        "app.kubernetes.io/name": 'jenkins'
        "app.kubernetes.io/managed-by": "Helm"
        "app.kubernetes.io/instance": "RELEASE-NAME"
        "app.kubernetes.io/component": "jenkins-controller"
    ```

List of contributions:

- Dylan Piergies: Replace Deployment with StatefulSet #33
- Aaron McDonald: move kubernetes plugin configuration under agent #106
- holmesb: Adding prometheus \ metrics guidance #78
- Florian Buchmeier: Updated UI tests to use official BATS image since
  dduportal/bats:0.4.0 is still using docker manifest v1 and thus is deprecated. (#157)

Closes #78

Co-authored-by: Aaron McDonald <[email protected]>
Co-authored-by: Dylan Piergies [email protected]
Co-authored-by: holmesb <[email protected]>
Signed-off-by: Torsten Walter <[email protected]>
torstenwalter referenced this pull request in torstenwalter/jenkins-helm-charts Nov 26, 2020
* Chart uses StatefulSet instead of Deployment
* XML configuration was dropped
* offending terms have been removed
* values have been renamed and re-ordered to make it easier to use
* already deprecated items got removed
* chart migrated to helm 3.0.0
* rename containers (#155)
* Configure admin user via configuration as code (#158)
  * admin username and password are no longer exposed as environment
    variables
  * admin password is not modified on helm updates instead the values from
    the existing secret is re-used
  * default length of admin password was increased
  * renamed useSecurity to adminSecret as disabling
    security feels odd and it's not what this flag does.
  * Check usage of deprecated imageTag (#161)
  * Remove whitespace when not rendering helm.sh/chart label (#160)
    Before:

    ```
    kind: PersistentVolumeClaim
    apiVersion: v1
    metadata:
      name: RELEASE-NAME-jenkins
      namespace: cockpit
      labels:
        "app.kubernetes.io/name": 'jenkins'

        "app.kubernetes.io/managed-by": "Helm"
        "app.kubernetes.io/instance": "RELEASE-NAME"
        "app.kubernetes.io/component": "jenkins-controller"
    ```

    After:

    ```
    kind: PersistentVolumeClaim
    apiVersion: v1
    metadata:
      name: RELEASE-NAME-jenkins
      namespace: cockpit
      labels:
        "app.kubernetes.io/name": 'jenkins'
        "app.kubernetes.io/managed-by": "Helm"
        "app.kubernetes.io/instance": "RELEASE-NAME"
        "app.kubernetes.io/component": "jenkins-controller"
    ```

List of contributions:

- Dylan Piergies: Replace Deployment with StatefulSet #33
- Aaron McDonald: move kubernetes plugin configuration under agent #106
- holmesb: Adding prometheus \ metrics guidance #78
- Florian Buchmeier: Updated UI tests to use official BATS image since
  dduportal/bats:0.4.0 is still using docker manifest v1 and thus is deprecated. (#157)

Closes #78

Co-authored-by: Aaron McDonald <[email protected]>
Co-authored-by: Dylan Piergies [email protected]
Co-authored-by: holmesb <[email protected]>
Signed-off-by: Torsten Walter <[email protected]>
torstenwalter added a commit that referenced this pull request Nov 26, 2020
* Chart uses StatefulSet instead of Deployment
* XML configuration was dropped
* offending terms have been removed
* values have been renamed and re-ordered to make it easier to use
* already deprecated items got removed
* chart migrated to helm 3.0.0
* rename containers (#155)
* Configure admin user via configuration as code (#158)
  * admin username and password are no longer exposed as environment
    variables
  * admin password is not modified on helm updates instead the values from
    the existing secret is re-used
  * default length of admin password was increased
  * renamed useSecurity to adminSecret as disabling
    security feels odd and it's not what this flag does.
  * Check usage of deprecated imageTag (#161)
  * Remove whitespace when not rendering helm.sh/chart label (#160)
    Before:

    ```
    kind: PersistentVolumeClaim
    apiVersion: v1
    metadata:
      name: RELEASE-NAME-jenkins
      namespace: cockpit
      labels:
        "app.kubernetes.io/name": 'jenkins'

        "app.kubernetes.io/managed-by": "Helm"
        "app.kubernetes.io/instance": "RELEASE-NAME"
        "app.kubernetes.io/component": "jenkins-controller"
    ```

    After:

    ```
    kind: PersistentVolumeClaim
    apiVersion: v1
    metadata:
      name: RELEASE-NAME-jenkins
      namespace: cockpit
      labels:
        "app.kubernetes.io/name": 'jenkins'
        "app.kubernetes.io/managed-by": "Helm"
        "app.kubernetes.io/instance": "RELEASE-NAME"
        "app.kubernetes.io/component": "jenkins-controller"
    ```

List of contributions:

- Dylan Piergies: Replace Deployment with StatefulSet #33
- Aaron McDonald: move kubernetes plugin configuration under agent #106
- holmesb: Adding prometheus \ metrics guidance #78
- Florian Buchmeier: Updated UI tests to use official BATS image since
  dduportal/bats:0.4.0 is still using docker manifest v1 and thus is deprecated. (#157)

Closes #78

Co-authored-by: Aaron McDonald <[email protected]>
Co-authored-by: Dylan Piergies [email protected]
Co-authored-by: holmesb <[email protected]>
Signed-off-by: Torsten Walter <[email protected]>

Co-authored-by: Aaron McDonald <[email protected]>
Co-authored-by: holmesb <[email protected]>
lemeurherve pushed a commit to lemeurherve/jenkinsci-helm-charts that referenced this pull request Dec 17, 2021
Some time ago (I honestly don't know when), `PROXY_ADDRESS_FORWARDING` was removed from the default environment variables but wasn't removed from default values in the README. This fix resolves the mismatch.

Signed-off-by: Mikhail Putilov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants