Rename containers #155
Merged
Rename containers #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Torsten Walter <[email protected]>
timja
approved these changes
Nov 24, 2020
torstenwalter
added a commit
that referenced
this pull request
Nov 26, 2020
* Chart uses StatefulSet instead of Deployment * XML configuration was dropped * offending terms have been removed * values have been renamed and re-ordered to make it easier to use * already deprecated items got removed * chart migrated to helm 3.0.0 * rename containers (#155) * Configure admin user via configuration as code (#158) * admin username and password are no longer exposed as environment variables * admin password is not modified on helm updates instead the values from the existing secret is re-used * default length of admin password was increased * renamed useSecurity to adminSecret as disabling security feels odd and it's not what this flag does. * Check usage of deprecated imageTag (#161) * Remove whitespace when not rendering helm.sh/chart label (#160) Before: ``` kind: PersistentVolumeClaim apiVersion: v1 metadata: name: RELEASE-NAME-jenkins namespace: cockpit labels: "app.kubernetes.io/name": 'jenkins' "app.kubernetes.io/managed-by": "Helm" "app.kubernetes.io/instance": "RELEASE-NAME" "app.kubernetes.io/component": "jenkins-controller" ``` After: ``` kind: PersistentVolumeClaim apiVersion: v1 metadata: name: RELEASE-NAME-jenkins namespace: cockpit labels: "app.kubernetes.io/name": 'jenkins' "app.kubernetes.io/managed-by": "Helm" "app.kubernetes.io/instance": "RELEASE-NAME" "app.kubernetes.io/component": "jenkins-controller" ``` List of contributions: - Dylan Piergies: Replace Deployment with StatefulSet #33 - Aaron McDonald: move kubernetes plugin configuration under agent #106 - holmesb: Adding prometheus \ metrics guidance #78 - Florian Buchmeier: Updated UI tests to use official BATS image since dduportal/bats:0.4.0 is still using docker manifest v1 and thus is deprecated. (#157) Closes #78 Co-authored-by: Aaron McDonald <[email protected]> Co-authored-by: Dylan Piergies [email protected] Co-authored-by: holmesb <[email protected]> Signed-off-by: Torsten Walter <[email protected]>
torstenwalter
referenced
this pull request
in torstenwalter/jenkins-helm-charts
Nov 26, 2020
* Chart uses StatefulSet instead of Deployment * XML configuration was dropped * offending terms have been removed * values have been renamed and re-ordered to make it easier to use * already deprecated items got removed * chart migrated to helm 3.0.0 * rename containers (#155) * Configure admin user via configuration as code (#158) * admin username and password are no longer exposed as environment variables * admin password is not modified on helm updates instead the values from the existing secret is re-used * default length of admin password was increased * renamed useSecurity to adminSecret as disabling security feels odd and it's not what this flag does. * Check usage of deprecated imageTag (#161) * Remove whitespace when not rendering helm.sh/chart label (#160) Before: ``` kind: PersistentVolumeClaim apiVersion: v1 metadata: name: RELEASE-NAME-jenkins namespace: cockpit labels: "app.kubernetes.io/name": 'jenkins' "app.kubernetes.io/managed-by": "Helm" "app.kubernetes.io/instance": "RELEASE-NAME" "app.kubernetes.io/component": "jenkins-controller" ``` After: ``` kind: PersistentVolumeClaim apiVersion: v1 metadata: name: RELEASE-NAME-jenkins namespace: cockpit labels: "app.kubernetes.io/name": 'jenkins' "app.kubernetes.io/managed-by": "Helm" "app.kubernetes.io/instance": "RELEASE-NAME" "app.kubernetes.io/component": "jenkins-controller" ``` List of contributions: - Dylan Piergies: Replace Deployment with StatefulSet #33 - Aaron McDonald: move kubernetes plugin configuration under agent #106 - holmesb: Adding prometheus \ metrics guidance #78 - Florian Buchmeier: Updated UI tests to use official BATS image since dduportal/bats:0.4.0 is still using docker manifest v1 and thus is deprecated. (#157) Closes #78 Co-authored-by: Aaron McDonald <[email protected]> Co-authored-by: Dylan Piergies [email protected] Co-authored-by: holmesb <[email protected]> Signed-off-by: Torsten Walter <[email protected]>
torstenwalter
added a commit
that referenced
this pull request
Nov 26, 2020
* Chart uses StatefulSet instead of Deployment * XML configuration was dropped * offending terms have been removed * values have been renamed and re-ordered to make it easier to use * already deprecated items got removed * chart migrated to helm 3.0.0 * rename containers (#155) * Configure admin user via configuration as code (#158) * admin username and password are no longer exposed as environment variables * admin password is not modified on helm updates instead the values from the existing secret is re-used * default length of admin password was increased * renamed useSecurity to adminSecret as disabling security feels odd and it's not what this flag does. * Check usage of deprecated imageTag (#161) * Remove whitespace when not rendering helm.sh/chart label (#160) Before: ``` kind: PersistentVolumeClaim apiVersion: v1 metadata: name: RELEASE-NAME-jenkins namespace: cockpit labels: "app.kubernetes.io/name": 'jenkins' "app.kubernetes.io/managed-by": "Helm" "app.kubernetes.io/instance": "RELEASE-NAME" "app.kubernetes.io/component": "jenkins-controller" ``` After: ``` kind: PersistentVolumeClaim apiVersion: v1 metadata: name: RELEASE-NAME-jenkins namespace: cockpit labels: "app.kubernetes.io/name": 'jenkins' "app.kubernetes.io/managed-by": "Helm" "app.kubernetes.io/instance": "RELEASE-NAME" "app.kubernetes.io/component": "jenkins-controller" ``` List of contributions: - Dylan Piergies: Replace Deployment with StatefulSet #33 - Aaron McDonald: move kubernetes plugin configuration under agent #106 - holmesb: Adding prometheus \ metrics guidance #78 - Florian Buchmeier: Updated UI tests to use official BATS image since dduportal/bats:0.4.0 is still using docker manifest v1 and thus is deprecated. (#157) Closes #78 Co-authored-by: Aaron McDonald <[email protected]> Co-authored-by: Dylan Piergies [email protected] Co-authored-by: holmesb <[email protected]> Signed-off-by: Torsten Walter <[email protected]> Co-authored-by: Aaron McDonald <[email protected]> Co-authored-by: holmesb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
It gives the containers more speaking names.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist