[JENKINS-74990] Prevent stack overflow / Revert 'Add icons for search' #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://issues.jenkins.io/browse/JENKINS-74990 notes that when a folder definition includes the XML: ``` <icon class="jenkins.branch.MetadataActionFolderIcon" plugin="[email protected]_a_3da_2eb_db_4"> <owner class="com.cloudbees.hudson.plugins.folder.Folder" reference="../.."/> </icon> ``` then the 6.971.v9a_984fd08864 release of the plugin reports a stack overflow. Revert the change so that there is enough time for diagnosis without the pressure of users reporting and diagnosing bugs. This reverts commit c9fe2ab.
MarkEWaite
changed the title
dwnusbaum
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[JENKINS-74990] Prevent stack overflow / Revert "Add icons for search"
JENKINS-74990 notes that when a folder definition includes the XML:
then the 6.971.v9a_984fd08864 release of the plugin reports a stack overflow.
Revert the change so that there is enough time for diagnosis without the pressure of users reporting and diagnosing bugs.
Change has no tests because I wanted to implement a quick solution so that users won't be affected.
This reverts commit c9fe2ab.
Testing done
Confirmed that the issue is visible without this change and is resolved with this change. Details in JENKINS-74990
Proposed changelog entries
Submitter checklist