Add icons for search

[timja]

Part of jenkinsci/jenkins#10049 but can be merged interdependently

Proposed changelog entries

• Entry 1: Issue, Human-readable Text
• ...

Submitter checklist

• JIRA issue is well described
• Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change).
  * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
• Appropriate autotests or explanation to why this change has no tests

[janfaracik]

For jenkinsci/jenkins#10049

missed IconSpec (ab)use

[MarkEWaite]

@timja and @jtnord I think that this release is causing a stack overflow on my Jenkins controller for both Jenkins 2.479.2 and Jenkins 2.489. Initial configurations that I'm using for my experiments are

• https://github.com/MarkEWaite/docker-lfs/commits/lts-with-plugins/
• https://github.com/MarkEWaite/docker-lfs/commits/weekly-with-plugins/

I need to do more exploring to narrow the steps to duplicate the issue. Will keep you informed as I learn more.

Stack trace is:

2024-12-12 19:58:39.937+0000 [id=20]    WARNING h.ExpressionFactory2$JexlExpression#evaluate: Caught exception evaluating: it.iconClassName in /. Reason: java.lang.reflect.InvocationTargetException
java.lang.StackOverflowError
        at hudson.ExtensionList.lookup(ExtensionList.java:437)
        at PluginClassLoader for cloudbees-folder//com.cloudbees.hudson.plugins.folder.relocate.RelocationUI.for_(RelocationUI.java:113)
        at PluginClassLoader for cloudbees-folder//com.cloudbees.hudson.plugins.folder.relocate.RelocationAction.<init>(RelocationAction.java:78)
        at PluginClassLoader for cloudbees-folder//com.cloudbees.hudson.plugins.folder.relocate.RelocationAction$TransientActionFactoryImpl.createFor(RelocationAction.java:176)
        at PluginClassLoader for cloudbees-folder//com.cloudbees.hudson.plugins.folder.relocate.RelocationAction$TransientActionFactoryImpl.createFor(RelocationAction.java:158)
        at hudson.model.Actionable.createFor(Actionable.java:118)
        at hudson.model.Actionable.getAction(Actionable.java:335)
        at PluginClassLoader for branch-api//jenkins.branch.MetadataActionFolderIcon.getIconClassName(MetadataActionFolderIcon.java:76)
        at PluginClassLoader for cloudbees-folder//com.cloudbees.hudson.plugins.folder.AbstractFolder.getIconClassName(AbstractFolder.java:311)
        at PluginClassLoader for branch-api//jenkins.branch.MetadataActionFolderIcon.getIconClassName(MetadataActionFolderIcon.java:104)
        at PluginClassLoader for cloudbees-folder//com.cloudbees.hudson.plugins.folder.AbstractFolder.getIconClassName(AbstractFolder.java:311)
        at PluginClassLoader for branch-api//jenkins.branch.MetadataActionFolderIcon.getIconClassName(MetadataActionFolderIcon.java:104)

[jtnord]

@timja and @jtnord I think that this release is causing a stack overflow on my Jenkins controller for both Jenkins 2.479.2 and Jenkins 2.489. Initial configurations that I'm using for my experiments are

• https://github.com/MarkEWaite/docker-lfs/commits/lts-with-plugins/
• https://github.com/MarkEWaite/docker-lfs/commits/weekly-with-plugins/

I need to do more exploring to narrow the steps to duplicate the issue. Will keep you informed as I learn more.

Stack trace is:

2024-12-12 19:58:39.937+0000 [id=20]    WARNING h.ExpressionFactory2$JexlExpression#evaluate: Caught exception evaluating: it.iconClassName in /. Reason: java.lang.reflect.InvocationTargetException
java.lang.StackOverflowError
        at hudson.ExtensionList.lookup(ExtensionList.java:437)
        at PluginClassLoader for cloudbees-folder//com.cloudbees.hudson.plugins.folder.relocate.RelocationUI.for_(RelocationUI.java:113)
        at PluginClassLoader for cloudbees-folder//com.cloudbees.hudson.plugins.folder.relocate.RelocationAction.<init>(RelocationAction.java:78)
        at PluginClassLoader for cloudbees-folder//com.cloudbees.hudson.plugins.folder.relocate.RelocationAction$TransientActionFactoryImpl.createFor(RelocationAction.java:176)
        at PluginClassLoader for cloudbees-folder//com.cloudbees.hudson.plugins.folder.relocate.RelocationAction$TransientActionFactoryImpl.createFor(RelocationAction.java:158)
        at hudson.model.Actionable.createFor(Actionable.java:118)
        at hudson.model.Actionable.getAction(Actionable.java:335)
        at PluginClassLoader for branch-api//jenkins.branch.MetadataActionFolderIcon.getIconClassName(MetadataActionFolderIcon.java:76)
        at PluginClassLoader for cloudbees-folder//com.cloudbees.hudson.plugins.folder.AbstractFolder.getIconClassName(AbstractFolder.java:311)
        at PluginClassLoader for branch-api//jenkins.branch.MetadataActionFolderIcon.getIconClassName(MetadataActionFolderIcon.java:104)
        at PluginClassLoader for cloudbees-folder//com.cloudbees.hudson.plugins.folder.AbstractFolder.getIconClassName(AbstractFolder.java:311)
        at PluginClassLoader for branch-api//jenkins.branch.MetadataActionFolderIcon.getIconClassName(MetadataActionFolderIcon.java:104)

Please file a revert pr and merge with your admin permissions if you see fit.
The code at the moment iiuc shouldn't be used by search so there would be not regression in the functionality. This then allows for a less stressful investigation

[MarkEWaite]

Thanks @jtnord . I filed:

• [JENKINS-74990] Prevent stack overflow / Revert 'Add icons for search' #451

I don't have enough permissions to merge the pull request, but will use the incremental until the release is available.

cloudbees-folder:incrementals;org.jenkins-ci.plugins;6.972.v69044ecb_d271

[dwnusbaum]

@MarkEWaite I approved and merged your PR, thanks!