Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove owner icon spec from metadata folder icon #497

Closed
wants to merge 1 commit into from

Conversation

timja
Copy link
Member

@timja timja commented Dec 15, 2024

see jenkinsci/cloudbees-folder-plugin#451, jenkinsci/cloudbees-folder-plugin#450 and jenkinsci/jenkins#10049

This was introduced in massive PR: #58
No idea if its actually used / still needed, will try to investigate.

Testing done

Tests in this plugin are passing
Tested in Bom PCT are passing jenkinsci/bom#4104

I'll try run this with a breakpoint on in a few setups and see if I can hit it

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@timja
Copy link
Member Author

timja commented Dec 16, 2024

Used in Organisation folders...

@timja timja closed this Dec 16, 2024
@timja timja deleted the remove-icon-spec-check branch December 16, 2024 22:25
@jglick
Copy link
Member

jglick commented Dec 16, 2024

Not sure in detail what this code is for, but from the description, it might be used only to set an icon for an org folder. Which is very cosmetic and something we could get rid of if it has some ill effect on performance. Compare jenkinsci/github-branch-source-plugin#700 (comment).

@timja
Copy link
Member Author

timja commented Dec 16, 2024

Not sure in detail what this code is for, but from the description, it might be used only to set an icon for an org folder. Which is very cosmetic and something we could get rid of if it has some ill effect on performance. Compare jenkinsci/github-branch-source-plugin#700 (comment).

Possibly, doesn't effect performance though just impacting the command palette, I've done a workaround in the folders plugin, not the cleanest but everything works: jenkinsci/cloudbees-folder-plugin#452

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants