Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove workaround in FreestyleJobTest#should_visit_build_with_permalink #1548

Closed
basil opened this issue May 14, 2024 · 0 comments · Fixed by #1572
Closed

Remove workaround in FreestyleJobTest#should_visit_build_with_permalink #1548

basil opened this issue May 14, 2024 · 0 comments · Fixed by #1572
Labels
tests

Comments

@basil
Copy link
Member

basil commented May 14, 2024

Starting with jenkinsci/jenkins#8110 by @janfaracik in 2.453, FreestyleJobTest#should_visit_build_with_permalink fails with

java.lang.AssertionError: 
Build has no changes
Expected: Text matching \QNo changes\E
     but: was "http://127.0.0.1:43213/job/indigenous_warning/lastBuild/"
"1\n2\nDashboard\nindigenous_warning\n#1\nStatus\nChanges\nConsole Output\nEdit Build Information\nDelete build ‘#1’\nKeep this build forever\nStarted 0.8 sec ago\nTook 18 ms\nSuccess\n#1 (May 14, 2024, 3:42:14 PM)\nAdd description\nStarted by anonymous user\nREST API\nJenkins 2.458"
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at core.FreestyleJobTest.should_visit_build_with_permalink(FreestyleJobTest.java:103)

This regression is tracked in core as JENKINS-73168.

This regression destabilized this test suite, as described in #1544. A workaround was added in this repository in #1547. As part of fixing JENKINS-73168, this workaround should be removed.
@basil basil added the tests label May 14, 2024
This was referenced May 14, 2024
Closed
Merged
Merged
MarkEWaite added a commit to MarkEWaite/acceptance-test-harness that referenced this issue May 21, 2024
@MarkEWaite
Enable "Build has no changes" assertion in FreestyleJobTest
b6ae940 
Assertion was disabled due to user interface change that has been modified
in Jenkins 2.459 to again report when the build has no changes.

https://issues.jenkins.io/browse/JENKINS-73168 fixes it in Jenkins 2.459.

jenkinsci#1548 is the
issue to remove the workaround.

Revert part of "Work around JENKINS-73034 (jenkinsci#1547)"

Tested by running the modified test with JENKINS_WAR set to a copy of the 2.459 Jenkins war file.

This reverts part of commit 4d71d1b.
@MarkEWaite MarkEWaite mentioned this issue May 21, 2024
Merged
6 tasks
basil pushed a commit that referenced this issue May 21, 2024
@MarkEWaite
Enable 'Build has no changes' assertion in FreestyleJobTest (#1572)
7da8433 
Enable "Build has no changes" assertion in FreestyleJobTest

Assertion was disabled due to user interface change that has been modified
in Jenkins 2.459 to again report when the build has no changes.

https://issues.jenkins.io/browse/JENKINS-73168 fixes it in Jenkins 2.459.

#1548 is the
issue to remove the workaround.

Revert part of "Work around JENKINS-73034 (#1547)"

Tested by running the modified test with JENKINS_WAR set to a copy of the 2.459 Jenkins war file.

This reverts part of commit 4d71d1b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable 'Build has no changes' assertion in FreestyleJobTest MarkEWaite/acceptance-test-harness
1 participant
@basil