[JENKINS-73168] Restore 'No changes' label when there are no changes in a build

[janfaracik]

See JENKINS-73168.

Will need some input on this, unsure if this is the right approach.

core/src/main/resources/hudson/model/AbstractBuild/changes.jelly uses ${it.changeSet} to load change sets, which returns an EmptyChangeLogSet when there are none. core/src/main/resources/jenkins/scm/RunWithSCM/changesets.jelly on the other hand uses ${it.changeSets} which returns an empty list. As a rather rudimentary fix I'm injecting the EmptyChangeLogSet digest.jelly when the list is empty - which works, albeit I'm not sure if these two files should be unified in their approach to loading change sets.

Testing done

• No changes label appears when there are no changes

Proposed changelog entries

• Restore 'No changes' label when there are no changes in a build. Regression in 2.453.

Proposed upgrade guidelines

N/A

Submitter checklist

Beta Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests.
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Beta Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[NotMyFault]

Thanks!

[MarkEWaite]

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

/label ready-for-merge

[basil]

Per JENKINS-73168 (comment):

As part of fixing this issue, the workaround in acceptance-test-harness should be removed per jenkinsci/acceptance-test-harness#1548, and the core pull request should ensure that FreestyleJobTest#should_visit_build_with_permalink is passing with the workaround removed.

[MarkEWaite]

Per JENKINS-73168 (comment):

As part of fixing this issue, the workaround in acceptance-test-harness should be removed per jenkinsci/acceptance-test-harness#1548, and the core pull request should ensure that FreestyleJobTest#should_visit_build_with_permalink is passing with the workaround removed.

Thanks for the reminder. Let me take that one as part of completing the weekly release.

Submitted:

• Enable 'Build has no changes' assertion in FreestyleJobTest acceptance-test-harness#1572