Work around JENKINS-73034 and JENKINS-73168 #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
commented
May 14, 2024
This was referenced May 14, 2024
MarkEWaite
added a commit
to MarkEWaite/acceptance-test-harness
that referenced
this pull request
May 21, 2024
Assertion was disabled due to user interface change that has been modified in Jenkins 2.459 to again report when the build has no changes. https://issues.jenkins.io/browse/JENKINS-73168 fixes it in Jenkins 2.459. jenkinsci#1548 is the issue to remove the workaround. Revert part of "Work around JENKINS-73034 (jenkinsci#1547)" Tested by running the modified test with JENKINS_WAR set to a copy of the 2.459 Jenkins war file. This reverts part of commit 4d71d1b.
basil
pushed a commit
that referenced
this pull request
May 21, 2024
Enable "Build has no changes" assertion in FreestyleJobTest Assertion was disabled due to user interface change that has been modified in Jenkins 2.459 to again report when the build has no changes. https://issues.jenkins.io/browse/JENKINS-73168 fixes it in Jenkins 2.459. #1548 is the issue to remove the workaround. Revert part of "Work around JENKINS-73034 (#1547)" Tested by running the modified test with JENKINS_WAR set to a copy of the 2.459 Jenkins war file. This reverts part of commit 4d71d1b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work around JENKINS-73034 and JENKINS-73168 to stabilize the test suite; those two tickets track the long-term fix. Once this is merged and the weekly line is green again, I will file two additional ATH tickets to remove these workarounds, blocked on JENKINS-73034 and JENKINS-73168 respectively.
Testing done
CI build of weekly line
Fixes #1544, fixes #1545