Skip to content

Artifact types#18

Closed
slide wants to merge 2 commits into
jenkins-infra:masterfrom
slide:artifact_types
Closed

Artifact types#18
slide wants to merge 2 commits into
jenkins-infra:masterfrom
slide:artifact_types

Conversation

@slide
Copy link
Copy Markdown
Contributor

@slide slide commented Jul 25, 2017

This adds the ability for people to define the artifact types that should be archived. Some "plugins" are actually libraries and generate jar files instead of jpi or hpi.

@rtyler
Copy link
Copy Markdown
Member

rtyler commented Jul 25, 2017

I'm not opposed to this change, though we're scope creeping what buildPlugin is supposed to do 😈

Do you have some examples to reference as a use-case? I'm not clear on which projects this would be used by?

@slide
Copy link
Copy Markdown
Contributor Author

slide commented Jul 25, 2017

I'm more than happy to pull out the common elements for plugin and library into a "buildCommon" which is called by buildPlugin/buildLibrary if that is a more desired approach. One "plugin" that uses jar artifacts is publish-over-plugin, which is not really a plugin, but a common library for the other publish-over-XXX plugins.

@oleg-nenashev
Copy link
Copy Markdown
Contributor

Another example are Jenkins Modules, which are packaged as JARs. Since #6 has been rejected (mostly my bad), right now we use buildPlugin() for their CI runs

@uhafner
Copy link
Copy Markdown
Contributor

uhafner commented Oct 9, 2017

Here is another example where the build fails because no hpi file is found.

At least we should use the parameter allowEmptyArchive: true

@oleg-nenashev
Copy link
Copy Markdown
Contributor

I have created #56 for libraries support. Maybe it would be better to use a separate method since we are adding more and more logic around buildPlugin().

WDYT @slide @uhafner ?

@slide slide closed this Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants