[INFRA-1459] - Initial implementation for the buildJenkinsComponent() step#56
[INFRA-1459] - Initial implementation for the buildJenkinsComponent() step#56oleg-nenashev wants to merge 1 commit into
Conversation
| junit '**/target/surefire-reports/TEST-*.xml' | ||
|
|
||
| if (archive) { | ||
| archiveArtifacts artifacts: '**/target/**/*.jar' |
There was a problem hiding this comment.
So I would delete this and replace with conditional Incrementals deployment, as done in buildPlugin.groovy.
There was a problem hiding this comment.
For things like Remoting it may be useful to publish the artifacts. But yes, maybe it should be opt-in (and configurable by YAML?)
There was a problem hiding this comment.
I agree on it being opt-in, however, I would ask that to be configurable via step param (and overridable in YAML) so that you can Replay and activate that if you need to debug instead of making a PR to modify the YAML file
| timestamps { | ||
| stage("Checkout (${stageIdentifier})") { | ||
| infra.checkout(repo) | ||
| isMaven = fileExists('pom.xml') |
There was a problem hiding this comment.
What is this variable? Seems unused?
There was a problem hiding this comment.
Yes, copy-paste leftovers I'd guess
|
Does it need to have Jenkins in the name? buildPlugin does not. |
| timeout(timeoutMin) { | ||
| timestamps { | ||
| stage("Checkout (${stageIdentifier})") { | ||
| infra.checkout(repo) |
There was a problem hiding this comment.
🐛 repo is not defined
| * @return nothing | ||
| */ | ||
| def buildSingle(String stageIdentifier, String nodeLabel, String jdk = 8, boolean archive = false, int timeoutMin = 60) { | ||
| node(label) { |
There was a problem hiding this comment.
🐛 Probably you mean nodeLabel
|
|
||
| if (archive) { | ||
| archiveArtifacts artifacts: '**/target/**/*.jar' | ||
| findbugs pattern: '**/target/findbugsXml.xml' |
There was a problem hiding this comment.
Why is findbugs guarded by if (archive)?
Is findbugs actually called?
| @@ -0,0 +1,66 @@ | |||
| #!/usr/bin/env groovy | |||
There was a problem hiding this comment.
cannot comment on the filename, and need to review this more fully some day, but I think this should be named buildComponent.
This would be more consistent with buildPlugin, and like for the plugins where we removed Jenkins because it's contextually obviously Jenkins related, I think this is the same here :).
| } | ||
|
|
||
| stage("Build (${stageIdentifier})") { | ||
| infra.runMaven(["--batch-mode", "clean", "install", "-Dmaven.test.failure.ignore=true"], jdk) |
There was a problem hiding this comment.
add -V (aka --show-versions)
|
Hello 👋 Of course, feel free to reopen if you are still working on it. Many thanks for the contribution proposal! |
7 participants
This is a minimal implementation of the
buildJenkinsComponent()step which is similar tobuildPlugin(). Generally we need to align the code and to add support of deployment to essentials.CC @jglick since he could probably share code for essentials deployment.
https://issues.jenkins-ci.org/browse/INFRA-1459
@reviewbybees @raul-arabaolaza @jglick