Skip to content

[WIP] Add Jenkinsfile, facelift and fix build#2

Merged
stopalopa merged 4 commits into
jenkinsci:masterfrom
batmat:add-Jenkinsfile
Jun 12, 2019
Merged

[WIP] Add Jenkinsfile, facelift and fix build#2
stopalopa merged 4 commits into
jenkinsci:masterfrom
batmat:add-Jenkinsfile

Conversation

@batmat
Copy link
Copy Markdown
Member

@batmat batmat commented Jun 6, 2019

No description provided.

@batmat
Copy link
Copy Markdown
Member Author

batmat commented Jun 6, 2019

Waiting on https://issues.jenkins-ci.org/browse/INFRA-2137 before pushing more commits

@oleg-nenashev
Copy link
Copy Markdown
Member

Not sure it will work for a non-plugin component.
See jenkins-infra/pipeline-library#56

Maybe a copy-paste of https://github.com/jenkinsci/custom-war-packager/blob/master/Jenkinsfile would do the job for now

@batmat
Copy link
Copy Markdown
Member Author

batmat commented Jun 7, 2019

ok, build seems to work, but failing because there's no test and Surefire is configured to bark in this case. I think I'll just add a first dummy test to get past this.

@batmat batmat force-pushed the add-Jenkinsfile branch from a6cdc23 to e092aad Compare June 8, 2019 12:27
@batmat batmat force-pushed the add-Jenkinsfile branch from e092aad to 3ad52ed Compare June 8, 2019 12:35
Copy link
Copy Markdown

@kwhetstone kwhetstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm for moving the Jenkinsfile creation to when tests are created.

Comment thread Jenkinsfile
@@ -0,0 +1 @@
buildPlugin(configurations: buildPlugin.recommendedConfigurations())
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is not a plugin, this might not work. I'm ok with adding a Jenkinsfile with the tests.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was fixing the merge conflicts and ended up merging everything. If this is going to be a problem, I can take it out.

<parent>
<artifactId>plugin-manager</artifactId>
<groupId>jenkins</groupId>
<groupId>io.jenkins.plugin-management</groupId>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 and for PR3, the package names can renamed during that cleanup

Comment thread pom.xml
</parent>
<packaging>pom</packaging>
<groupId>io.jenkins.plugin-management</groupId>
<artifactId>jenkins-plugin-management-parent-pom</artifactId>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the new artifact id should match the repository name jenkins-plugin-installation-manager

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already merged this. I also thought that the artifactId had to match the repository name, but for the custom war packager it also does not match: https://github.com/jenkinsci/custom-war-packager/blob/master/pom.xml

@stopalopa stopalopa merged commit 0a6fc22 into jenkinsci:master Jun 12, 2019
@oleg-nenashev
Copy link
Copy Markdown
Member

As I said, the buildPlugin() pipeline does not work for non-plugin components anymore: #2 (comment)

[2019-06-08T12:36:36.080Z] Archiving artifacts
[2019-06-08T12:36:36.101Z] ‘**/target/*.hpi’ doesn’t match anything: ‘**’ exists but not ‘**/target/*.hpi’
No artifacts found that match the file pattern "**/target/*.hpi,**/target/*.jpi". Configuration error?

@kwhetstone
Copy link
Copy Markdown

PR#3 should fix the pipeline; we know it's failing and have an idea of what needs to be added to build successfully.

@batmat batmat deleted the add-Jenkinsfile branch June 18, 2019 06:38
stopalopa added a commit that referenced this pull request Jun 20, 2019
Update repo with PR Merges from Jenkinsci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants