[WIP] Add Jenkinsfile, facelift and fix build#2
Conversation
|
Waiting on https://issues.jenkins-ci.org/browse/INFRA-2137 before pushing more commits |
|
Not sure it will work for a non-plugin component. Maybe a copy-paste of https://github.com/jenkinsci/custom-war-packager/blob/master/Jenkinsfile would do the job for now |
|
ok, build seems to work, but failing because there's no test and Surefire is configured to bark in this case. I think I'll just add a first dummy test to get past this. |
kwhetstone
left a comment
There was a problem hiding this comment.
I'm for moving the Jenkinsfile creation to when tests are created.
| @@ -0,0 +1 @@ | |||
| buildPlugin(configurations: buildPlugin.recommendedConfigurations()) | |||
There was a problem hiding this comment.
Since this is not a plugin, this might not work. I'm ok with adding a Jenkinsfile with the tests.
There was a problem hiding this comment.
Sorry, I was fixing the merge conflicts and ended up merging everything. If this is going to be a problem, I can take it out.
| <parent> | ||
| <artifactId>plugin-manager</artifactId> | ||
| <groupId>jenkins</groupId> | ||
| <groupId>io.jenkins.plugin-management</groupId> |
There was a problem hiding this comment.
+1 and for PR3, the package names can renamed during that cleanup
| </parent> | ||
| <packaging>pom</packaging> | ||
| <groupId>io.jenkins.plugin-management</groupId> | ||
| <artifactId>jenkins-plugin-management-parent-pom</artifactId> |
There was a problem hiding this comment.
Maybe the new artifact id should match the repository name jenkins-plugin-installation-manager
There was a problem hiding this comment.
I already merged this. I also thought that the artifactId had to match the repository name, but for the custom war packager it also does not match: https://github.com/jenkinsci/custom-war-packager/blob/master/pom.xml
|
As I said, the |
|
PR#3 should fix the pipeline; we know it's failing and have an idea of what needs to be added to build successfully. |
Update repo with PR Merges from Jenkinsci
No description provided.