Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the project version to 2026.5.11 across various configuration files, documentation, and shell completion scripts. It also includes updates to the changelog, aqua-registry metadata, and the repository star count in the documentation. Feedback was provided regarding the shell completion scripts for Zsh, Bash, Fish, and PowerShell, noting that using fixed filenames in shared temporary directories can lead to collisions or security vulnerabilities (CWE-377). It is recommended to include user-specific identifiers in the temporary file paths to ensure environment isolation and security.
| fi | ||
|
|
||
| local spec_file="${TMPDIR:-/tmp}/usage__usage_spec_mise_2026_5_10.spec" | ||
| local spec_file="${TMPDIR:-/tmp}/usage__usage_spec_mise_2026_5_11.spec" |
There was a problem hiding this comment.
Using a fixed filename in a shared temporary directory (/tmp) can lead to collisions between different users on the same system. Since the completion spec may vary based on the user's environment and installed plugins, the cache should be user-specific to ensure correctness and security (CWE-377).
local spec_file="${TMPDIR:-/tmp}/usage__usage_spec_mise_${EUID}_2026_5_11.spec"
| local cur prev words cword was_split comp_args | ||
| _comp_initialize -n : -- "$@" || return | ||
| local spec_file="${TMPDIR:-/tmp}/usage__usage_spec_mise_2026_5_10.spec" | ||
| local spec_file="${TMPDIR:-/tmp}/usage__usage_spec_mise_2026_5_11.spec" |
There was a problem hiding this comment.
Using a fixed filename in a shared temporary directory (/tmp) can lead to collisions between different users on the same system. Since the completion spec may vary based on the user's environment and installed plugins, the cache should be user-specific to ensure correctness and security (CWE-377).
local spec_file="${TMPDIR:-/tmp}/usage__usage_spec_mise_${EUID}_2026_5_11.spec"
| end | ||
| set -l tmpdir (if set -q TMPDIR; echo $TMPDIR; else; echo /tmp; end) | ||
| set -l spec_file "$tmpdir/usage__usage_spec_mise_2026_5_10.spec" | ||
| set -l spec_file "$tmpdir/usage__usage_spec_mise_2026_5_11.spec" |
There was a problem hiding this comment.
Using a fixed filename in a shared temporary directory (/tmp) can lead to collisions between different users on the same system. Since the completion spec may vary based on the user's environment and installed plugins, the cache should be user-specific to ensure correctness and security (CWE-377).
set -l spec_file "$tmpdir/usage__usage_spec_mise_$USER_2026_5_11.spec"
|
|
||
| $tmpDir = if ($env:TEMP) { $env:TEMP } else { [System.IO.Path]::GetTempPath() } | ||
| $specFile = Join-Path $tmpDir "usage__usage_spec_mise_2026_5_10.kdl" | ||
| $specFile = Join-Path $tmpDir "usage__usage_spec_mise_2026_5_11.kdl" |
There was a problem hiding this comment.
Using a fixed filename in the temporary directory can lead to collisions between different users on the same system. Since the completion spec may vary based on the user's environment and installed plugins, the cache should be user-specific. Additionally, this file uses the .kdl extension while other shell completion scripts use .spec; consider using a consistent extension across all shells.
$specFile = Join-Path $tmpDir "usage__usage_spec_mise_$($env:USERNAME)_2026_5_11.kdl"
Greptile SummaryThis is the automated release PR for mise v2026.5.11, bumping the version across all packaging files and updating the changelog, completions, and vendored aqua-registry.
Confidence Score: 5/5Routine automated release commit — all changes are version string replacements, generated completion files, changelog entries, and an upstream aqua-registry vendor bump with no hand-written logic. Every changed file is either a mechanical version bump, a generated artifact, or a vendored upstream registry update. No application logic, auth paths, or data-handling code was modified. No files require special attention; the most complex diff is the aqua-registry registry.yml vendor update, but it originates from the upstream aqua-registry v4.512.1 tag. Important Files Changed
Reviews (12): Last reviewed commit: "chore: release 2026.5.11" | Re-trigger Greptile |
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.5.10 x -- echo |
18.2 ± 0.8 | 16.6 | 21.9 | 1.00 |
mise x -- echo |
18.6 ± 0.9 | 16.3 | 29.0 | 1.02 ± 0.07 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.5.10 env |
18.2 ± 0.9 | 16.5 | 23.1 | 1.00 |
mise env |
18.3 ± 0.8 | 16.6 | 20.8 | 1.01 ± 0.07 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.5.10 hook-env |
19.1 ± 0.9 | 17.4 | 23.5 | 1.00 |
mise hook-env |
19.3 ± 0.9 | 17.4 | 22.9 | 1.01 ± 0.06 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.5.10 ls |
15.6 ± 0.7 | 13.8 | 18.7 | 1.00 |
mise ls |
15.8 ± 0.7 | 14.1 | 19.9 | 1.01 ± 0.07 |
xtasks/test/perf
| Command | mise-2026.5.10 | mise | Variance |
|---|---|---|---|
| install (cached) | 130ms | 134ms | -2% |
| ls (cached) | 57ms | 59ms | -3% |
| bin-paths (cached) | 65ms | 65ms | +0% |
| task-ls (cached) | 121ms | 124ms | -2% |
561d121 to
567cbdd
Compare
3a55f49 to
908d1e4
Compare
🐛 Bug Fixes
🚜 Refactor
📚 Documentation
🛡️ Security
📦️ Dependency Updates
📦 Registry
Chore
New Contributors
📦 Aqua Registry Updates
New Packages (1)
glossia/cliUpdated Packages (1)
dathere/qsv