fix(vfox): use selected install path for env keys#9907
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the vfox backend to support explicit installation directories when retrieving environment keys. Key changes include the introduction of env_keys_for_install_dir in the vfox crate, updating the VfoxBackend to incorporate the installation path into its cache key and cache freshness checks, and adding an end-to-end test for system binary paths. I have no feedback to provide as there were no review comments to evaluate.
Greptile SummaryThis PR fixes vfox env key resolution for system-installed tools by threading the resolved
Confidence Score: 5/5Safe to merge — changes are narrowly scoped to the vfox env-key path and cache logic, with no regressions on the existing code path. The fix is well-targeted: the root cause (hardcoded install-dir construction in the hook call and the cache hash) is corrected at both layers, the existing env_keys public API is preserved unchanged by delegating to the new shared helper, and the e2e test validates the system-install scenario end-to-end. No files require special attention. Important Files Changed
Reviews (2): Last reviewed commit: "test(vfox): use platform separator in en..." | Re-trigger Greptile |
Summary
ToolVersioninstall path into traditional vfoxEnvKeyshookspoetrytoolFixes part of #9857.
Testing
cargo fmt --checkgit diff --checkCARGO_TARGET_DIR=/tmp/mise-m7-vfox-test /home/risu/.rustup/toolchains/1.95.0-x86_64-unknown-linux-gnu/bin/cargo test -p vfox test_env_keys_for_install_dirCARGO_TARGET_DIR=/tmp/mise-m7-e2e-target mise run test:e2e e2e/backend/test_vfox_system_bin_paths