fix(erlang): respect compile false for precompiled installs#9866
Conversation
There was a problem hiding this comment.
Code Review
This pull request implements stricter enforcement for Erlang precompiled binary usage. It introduces a precompiled_unavailable helper in src/plugins/core/erlang.rs that triggers a failure if erlang.compile is disabled and binaries cannot be found, rather than silently falling back. An E2E test was also added to validate this behavior on unsupported platforms. I have no feedback to provide.
Greptile SummaryThis PR introduces a
Confidence Score: 5/5The change is safe to merge; it only tightens an explicit opt-in ( The core logic change is small and well-scoped: the new No files require special attention. Important Files Changed
Reviews (3): Last reviewed commit: "test(erlang): match shell test formattin..." | Re-trigger Greptile |
Summary
core:erlangtreaterlang.compile=falseas strict precompiled mode instead of falling back tokerlkerlwhenerlang.compileis unset, and keepcompile=truesource-onlyImageOS=nobara-43) that asserts nobuild-installfallback happensInvestigation
Discussion #9433 shows
Unsupported OS version: nobara-43, followed bykerl build-install. Python and Node already bail whencompile=falsecannot find a precompiled artifact. Ruby is different and currently documents fallback behavior forruby.compile=false.Validation
cargo fmt --checkgit diff --checkshellcheck e2e/core/test_erlang_precompiled_strictmise run buildmise run test:e2e e2e/core/test_erlang_precompiled_strictDiscussion: #9433
This PR description was generated by an AI coding assistant.