Skip to content

registry: use aqua backend for npm#9762

Merged
jdx merged 4 commits into
jdx:mainfrom
risu729:test/npm-aqua-followup
May 14, 2026
Merged

registry: use aqua backend for npm#9762
jdx merged 4 commits into
jdx:mainfrom
risu729:test/npm-aqua-followup

Conversation

@risu729

@risu729 risu729 commented May 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Reopens registry: use aqua backend for npm #8185 with only the registry/npm.toml change.
  • Prefer aqua:npm/cli while keeping npm:npm as the fallback backend.
  • Add the node dependency required to run the npm JavaScript entrypoint.
  • Keep the registry test as npm --version; it should not check node --version.
  • Update the backend-arg unit test now that bare npm resolves through the registry to aqua:npm/cli.
  • Keep explicit coverage for npm:npm as the npm backend form.
  • Clarify why the npm backend still waits for node when bootstrapping npm:npm.

Notes

Testing

  • cargo test test_bare_
  • cargo test test_get_dependencies_for_npm_itself
  • cargo fmt --check
  • git diff --check

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the npm registry configuration to prioritize the aqua:npm/cli backend. It includes a clarifying comment in the NPM backend implementation regarding bootstrapping and updates the CLI argument parsing tests to ensure that a bare 'npm' input correctly resolves to the Aqua backend. I have no feedback to provide as there were no review comments.

@greptile-apps

greptile-apps Bot commented May 10, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR updates the mise registry so that bare npm prefers the aqua:npm/cli backend while keeping npm:npm as the fallback, matching the pattern used by other tools that have graduated to the aqua backend.

  • registry/npm.toml: adds aqua:npm/cli as the first-choice backend; npm:npm is retained so the fallback path is intact until the upstream aqua-registry PR (#48803) merges.
  • src/backend/npm.rs: replaces a stale comment with a clear explanation of why node remains a dependency when bootstrapping through the npm:npm path even after the registry shorthand moves to aqua.
  • src/cli/args/backend_arg.rs: splits the old bare-npm test into an explicit npm:npm case and a new async registry-resolution test asserting bare npm resolves to aqua:npm/cli.

Confidence Score: 5/5

Safe to merge — the change is additive (aqua backend is preferred, npm:npm fallback is preserved) and the only runtime behaviour change is when the aqua-registry entry for npm/cli eventually lands.

The registry change is minimal and non-breaking: existing npm:npm users are unaffected, bare-npm users will seamlessly fall back until the upstream aqua PR merges, and the updated tests correctly cover both the explicit and registry-resolved code paths.

No files require special attention.

Important Files Changed

Filename Overview
registry/npm.toml Adds aqua:npm/cli as the preferred backend with npm:npm kept as the fallback; the rest of the file is unchanged.
src/backend/npm.rs Comment-only change that clarifies why node is kept as a dependency for the npm:npm bootstrap path even after the registry shorthand moves to aqua.
src/cli/args/backend_arg.rs Splits the old bare-npm test into two: an explicit npm:npm test and a new async test verifying bare npm resolves through the registry to aqua:npm/cli.

Reviews (2): Last reviewed commit: "Merge branch 'main' into test/npm-aqua-f..." | Re-trigger Greptile

@risu729

This comment was marked as outdated.

@risu729 risu729 changed the title test(backend): update npm registry expectations registry: use aqua backend for npm May 10, 2026
@risu729 risu729 marked this pull request as ready for review May 14, 2026 15:07
@jdx jdx merged commit c4dda65 into jdx:main May 14, 2026
32 of 33 checks passed
@risu729 risu729 deleted the test/npm-aqua-followup branch May 14, 2026 20:46
mise-en-dev added a commit that referenced this pull request May 15, 2026
### 🚀 Features

- **(config)** add shell to watch_files run by @risu729 in
[#9810](#9810)
- **(spm)** add artifact bundle support by @ikesyo in
[#9825](#9825)

### 🐛 Bug Fixes

- **(aqua)** reject registry-invalid latest tags by @risu729 in
[#9834](#9834)
- **(patrons)** point sponsor link to https://en.dev by @jdx in
[#9868](#9868)
- **(vfox)** respect default inline shell in cmd.exec by @risu729 in
[#9837](#9837)
- github oauth device flow paths by @jasisk in
[#9791](#9791)

### 📚 Documentation

- Update Walkthrough guide by @thernstig in
[#9853](#9853)

### ⚡ Performance

- **(config)** skip tera render for plain strings by @risu729 in
[#9833](#9833)

### 📦️ Dependency Updates

- update ghcr.io/jdx/mise:rpm docker digest to d2471f2 by @renovate[bot]
in [#9879](#9879)
- update rust docker digest to 5b1e348 by @renovate[bot] in
[#9880](#9880)
- update ghcr.io/jdx/mise:deb docker digest to 0cde829 by @renovate[bot]
in [#9878](#9878)
- update ubuntu docker tag to resolute-20260421 by @renovate[bot] in
[#9881](#9881)
- update ghcr.io/jdx/mise:alpine docker digest to 2d0ea74 by
@renovate[bot] in [#9877](#9877)
- update rust crate phf to 0.13 by @renovate[bot] in
[#9884](#9884)
- update rust crate phf_codegen to 0.13 by @renovate[bot] in
[#9883](#9883)

### 📦 Registry

- use aqua backend for npm by @risu729 in
[#9762](#9762)
- add aqua for buck2 prereleases by @risu729 in
[#9805](#9805)
- add SonarQube CLI
([aqua:SonarSource/sonarqube-cli](https://github.com/SonarSource/sonarqube-cli))
by @3PeatVR in [#9824](#9824)

### New Contributors

- @3PeatVR made their first contribution in
[#9824](#9824)
- @ikesyo made their first contribution in
[#9825](#9825)
- @thernstig made their first contribution in
[#9853](#9853)

## 📦 Aqua Registry Updates

### New Packages (4)

- [`SurgeDM/Surge`](https://github.com/SurgeDM/Surge)
- [`roie/ovw`](https://github.com/roie/ovw)
- [`so-dang-cool/sigi`](https://github.com/so-dang-cool/sigi)
- [`vjeantet/alerter`](https://github.com/vjeantet/alerter)

### Updated Packages (2)

-
[`alltuner/mise-completions-sync`](https://github.com/alltuner/mise-completions-sync)
-
[`str4d/age-plugin-yubikey`](https://github.com/str4d/age-plugin-yubikey)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants