feat(config): add shell to watch_files run#9810
Conversation
Greptile SummaryThis PR adds an optional
Confidence Score: 5/5Safe to merge — the change is well-scoped, correctly falls back to the existing default shell, and the previous silent-ignore of All three layers (runtime warning, schema enforcement, e2e tests) are in place. The refactor from No files require special attention. Important Files Changed
Reviews (6): Last reviewed commit: "Merge branch 'main' into feat/watch-file..." | Re-trigger Greptile |
There was a problem hiding this comment.
Code Review
This pull request introduces a shell option for watch_files hooks, allowing users to specify a custom inline shell command instead of relying on the default. The changes include updates to the documentation, JSON schema, configuration parsing, and the execution logic in src/watch_files.rs, supported by a new end-to-end test. Feedback was provided regarding the eager evaluation of the default shell in the execute function, suggesting an optimization to avoid unnecessary overhead when a custom shell is already defined.
This comment was marked as outdated.
This comment was marked as outdated.
### 🚀 Features - **(config)** add shell to watch_files run by @risu729 in [#9810](#9810) - **(spm)** add artifact bundle support by @ikesyo in [#9825](#9825) ### 🐛 Bug Fixes - **(aqua)** reject registry-invalid latest tags by @risu729 in [#9834](#9834) - **(patrons)** point sponsor link to https://en.dev by @jdx in [#9868](#9868) - **(vfox)** respect default inline shell in cmd.exec by @risu729 in [#9837](#9837) - github oauth device flow paths by @jasisk in [#9791](#9791) ### 📚 Documentation - Update Walkthrough guide by @thernstig in [#9853](#9853) ### ⚡ Performance - **(config)** skip tera render for plain strings by @risu729 in [#9833](#9833) ### 📦️ Dependency Updates - update ghcr.io/jdx/mise:rpm docker digest to d2471f2 by @renovate[bot] in [#9879](#9879) - update rust docker digest to 5b1e348 by @renovate[bot] in [#9880](#9880) - update ghcr.io/jdx/mise:deb docker digest to 0cde829 by @renovate[bot] in [#9878](#9878) - update ubuntu docker tag to resolute-20260421 by @renovate[bot] in [#9881](#9881) - update ghcr.io/jdx/mise:alpine docker digest to 2d0ea74 by @renovate[bot] in [#9877](#9877) - update rust crate phf to 0.13 by @renovate[bot] in [#9884](#9884) - update rust crate phf_codegen to 0.13 by @renovate[bot] in [#9883](#9883) ### 📦 Registry - use aqua backend for npm by @risu729 in [#9762](#9762) - add aqua for buck2 prereleases by @risu729 in [#9805](#9805) - add SonarQube CLI ([aqua:SonarSource/sonarqube-cli](https://github.com/SonarSource/sonarqube-cli)) by @3PeatVR in [#9824](#9824) ### New Contributors - @3PeatVR made their first contribution in [#9824](#9824) - @ikesyo made their first contribution in [#9825](#9825) - @thernstig made their first contribution in [#9853](#9853) ## 📦 Aqua Registry Updates ### New Packages (4) - [`SurgeDM/Surge`](https://github.com/SurgeDM/Surge) - [`roie/ovw`](https://github.com/roie/ovw) - [`so-dang-cool/sigi`](https://github.com/so-dang-cool/sigi) - [`vjeantet/alerter`](https://github.com/vjeantet/alerter) ### Updated Packages (2) - [`alltuner/mise-completions-sync`](https://github.com/alltuner/mise-completions-sync) - [`str4d/age-plugin-yubikey`](https://github.com/str4d/age-plugin-yubikey)
Summary
shellsupport for[[watch_files]]entries that userunshellthrough config templates and fall back to the configured default inline shell args when unsetTesting
cargo fmt --checkjq empty schema/mise.jsonmise run test:e2e config/test_watch_files_shellmise run test:unitwas stopped while still queued behind the shared Cargo wrapper semaphore; CI will run the full suite.This PR was generated by an AI coding assistant.