Skip to content

registry: use aqua backend for npm#8185

Closed
risu729 wants to merge 3 commits into
jdx:mainfrom
risu729:npm-aqua
Closed

registry: use aqua backend for npm#8185
risu729 wants to merge 3 commits into
jdx:mainfrom
risu729:npm-aqua

Conversation

@risu729

@risu729 risu729 commented Feb 16, 2026

Copy link
Copy Markdown
Contributor

This should avoid some bugs caused by npm:npm.
I'll open a PR to aqua-registry. aquaproj/aqua-registry#48803

npm bundles all of its dependencies, so it works like a single binary (but a JavaScript file, so node is required).

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @risu729, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the npm package manager into the aqua registry system by defining its installation details and updating its configuration. The changes ensure that npm can be managed effectively through aqua, improving consistency and dependency handling for JavaScript projects. Additionally, a build script enhancement guarantees that registry changes are always reflected in the build output.

Highlights

  • New Aqua Registry Entry for npm: A new registry.yaml file has been added to define how the npm CLI tool is managed within the aqua registry, specifying its download URL, archive format, and extraction paths for npm and npx binaries, including Windows-specific .cmd files.
  • Build Script Reliability Improvement: The build.rs script has been updated to include a cargo:rerun-if-changed directive, ensuring that the build process is re-executed whenever changes occur within the aqua-registry directory, preventing stale builds.
  • npm Configuration Update: The npm.toml configuration has been modified to prioritize the newly added aqua:npm/cli backend for npm and to explicitly declare node as a dependency for npm.
Changelog
  • crates/aqua-registry/aqua-registry/pkgs/npm/cli/registry.yaml
    • Added a new aqua-registry definition for the npm CLI, including binary paths and Windows overrides.
  • crates/aqua-registry/build.rs
    • Updated the build script to re-run if the registry directory content changes.
  • registry/npm.toml
    • Updated the npm configuration to prioritize the aqua backend.
    • Added a node dependency for npm.
Activity
  • No activity has occurred on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an aqua backend for npm, making it the preferred installation method. This is achieved by adding a new aqua registry definition for npm/cli, updating npm.toml to prioritize the aqua backend, and specifying its dependency on node. Additionally, the build script for the aqua registry is improved to correctly trigger rebuilds when registry files change. The changes are well-implemented and improve how npm is managed.

@github-actions

Copy link
Copy Markdown

This PR has been open for more than 30 days without activity. Note: CI checks were failing, which may be why it wasn't reviewed. Feel free to reopen or create a new PR if you'd like to continue working on this.

@github-actions github-actions Bot closed this Mar 19, 2026
@risu729 risu729 deleted the npm-aqua branch May 9, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant