feat(registry): Add imagemagick github backend entry for Windows binary releases#8476
feat(registry): Add imagemagick github backend entry for Windows binary releases#8476iki wants to merge 5 commits into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully adds a GitHub backend entry for ImageMagick, enabling installation on Windows by specifying platform-specific asset patterns. The changes correctly refactor the backends definition from a simple array to an array of tables, which is necessary to support the detailed platform options. The TOML syntax is correct and aligns with the intended functionality for handling GitHub binary releases.
Note: Security Review has been skipped due to the limited scope of the PR.
Greptile SummaryThis PR adds a Key points:
Confidence Score: 3/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[mise install imagemagick] --> B{OS filter\nregistryTool.backends}
B -->|non-Windows| C[conda:imagemagick]
B -->|non-Windows| D[asdf:mise-plugins/mise-imagemagick]
B -->|platforms contains 'windows'| E[github:ImageMagick/ImageMagick]
E --> F{lookup_platform_key\nplatforms.OS-ARCH.asset_pattern}
F -->|windows-x64| G["ImageMagick-*-portable-Q16-HDRI-x64.7z"]
F -->|windows-arm64| H["ImageMagick-*-portable-Q16-HDRI-arm64.7z"]
F -->|windows-x86 ❌ missing| I[Falls back to auto-detection\nmay fail]
G --> J[Download & install .7z archive]
H --> J
Last reviewed commit: 4bd1fb4 |
|
@gemini-code-assist review and summarize |
There was a problem hiding this comment.
Code Review
This pull request adds a GitHub backend for ImageMagick to support Windows binary releases. The implementation is functionally correct, but I've suggested an improvement to the TOML configuration to make it more readable and maintainable by grouping related platform options.
Note: Security Review has been skipped due to the limited scope of the PR.
…ments Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
@gemini-code-assist review and summarize |
There was a problem hiding this comment.
Code Review
This pull request adds a GitHub backend for imagemagick to support installation on Windows. The changes to registry/imagemagick.toml correctly refactor the backends definition to an array of tables and add the new GitHub backend. However, there is an issue with one of the platform keys used, which violates the registry schema as detailed in the comment.
Note: Security Review has been skipped due to the limited scope of the PR.
|
@gemini-code-assist review and summarize |
There was a problem hiding this comment.
Code Review
This pull request adds a GitHub backend for ImageMagick on Windows, allowing for direct installation of binary releases. The changes correctly restructure the imagemagick.toml file to accommodate the new backend. My review includes a suggestion to add support for the windows-x86 architecture, which appears to be available in the releases but was missed in the current implementation.
Note: Security Review has been skipped due to the limited scope of the PR.
|
I think it might be best to try to get this into aqua registry instead |
|
Could we get this in the meantime until it's added to aqua registry? My netlify builds are taking a long time because I need imagemagick and they don't give me access to the system package manager but they have mise so I install imagemagick with mise on Linux as part of my build but it takes a long time to install because it has to compile from source. |
|
@suchipi: It is already in aqua registry since aquaproj/aqua-registry#50281, you can use For updating mise registry see current #10118 |
|
thank you! |
|
@suchipi: Actually on Linux it doesn't work yet as mise does not support AppImage archives currently: #10118 (comment) It may be unblocked by ImageMagick adding static Linux build archive: ImageMagick/ImageMagick#8792 In meantime, you may try to install aqua and use it to install ImageMagick, it works on Windows: mise use -g aqua
aqua g -i ImageMagick/ImageMagick && aqua i |
Follow-up to #8386 discussion on
imagemagick, where #8388 fixed the message and this PR aims to add a github binary releases backend toimagemagickregistry entry to allow installing on Windows.Currently, I'm able to install
imagemagickon Windows from its binary releases on https://github.com/ImageMagick/ImageMagick/releases using the following entry in~/.config/mise/config.toml:Here's an attempt to define that backend in
registry/imagemagick.toml:Is there any way how to test it locally @jdx?