registry: add imagemagick backend aqua:ImageMagick/ImageMagick for Windows support by iki · Pull Request #10214 · jdx/mise

iki · 2026-06-03T20:22:34Z

It is required to install mise use -g imagemagick on Windows. Current backends conda and asdf in registry/imagemagick.toml don't support Windows.

I followed @jdx suggestion in #8476 to add ImageMagick directly to aqua registry. That was completed in aquaproj/aqua-registry#50281 and works OK aqua g -i ImageMagick/ImageMagick && aqua i.

⚠️ Blocked by #10215

…ndows support

coderabbitai · 2026-06-03T20:22:46Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5ecb7229-426a-45ab-a9db-2b0c438fbc0d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

greptile-apps · 2026-06-03T20:27:45Z

Greptile Summary

Adds aqua:ImageMagick/ImageMagick as the first (default) backend in registry/imagemagick.toml, filling a gap on Windows where the existing conda and asdf backends are unavailable. The aqua entry was recently merged into the aqua-registry (aquaproj/aqua-registry#50281) and verified to work.

Prepends aqua:ImageMagick/ImageMagick to the backends list so it is tried first on all platforms, including Windows.
conda:imagemagick and asdf:mise-plugins/mise-imagemagick remain as fallbacks for platforms where aqua is not configured.
The pre-existing commented-out test line is unchanged; other aqua-backed tools in the registry do have their tests enabled, so this could be revisited.

Confidence Score: 5/5

Safe to merge — the change is a single-line addition of a well-tested aqua backend with no logic changes.

The change touches only one registry entry file and adds a backend that was verified working by the author. The existing fallback backends are preserved, so there is no regression risk for users on platforms where aqua is not set up.

No files require special attention.

Important Files Changed

Filename	Overview
registry/imagemagick.toml	Adds `aqua:ImageMagick/ImageMagick` as the first (highest-priority) backend, enabling Windows support; the commented-out test remains disabled.

_{Reviews (1): Last reviewed commit: "registry: add imagemagick backend aqua:I..." | Re-trigger Greptile}

greptile-apps · 2026-06-03T20:27:49Z

-backends = ["conda:imagemagick", "asdf:mise-plugins/mise-imagemagick"]
+backends = ["aqua:ImageMagick/ImageMagick", "conda:imagemagick", "asdf:mise-plugins/mise-imagemagick"]
 description = "ImageMagick is a free, open-source software suite for creating, editing, converting, and displaying images. It supports 200+ formats and offers powerful command-line tools and APIs for automation, scripting, and integration across platforms"
 # test = { cmd = "magick --version", expected = "ImageMagick" }


Commented-out test still disabled

Now that aqua:ImageMagick/ImageMagick is the first backend and provides cross-platform (including Windows) support, it may be a good time to revisit enabling this test. Other aqua-backed registry entries (e.g. act.toml, 1password.toml) have their tests enabled. Consider uncommenting test = { cmd = "magick --version", expected = "ImageMagick" } if the aqua package exposes the magick binary — just confirm the binary name matches what the aqua registry entry ships.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

thernstig · 2026-06-04T12:44:49Z

@iki did you see #10118?

github-actions · 2026-06-05T00:26:55Z

This PR currently has failing checks. If this continues for 7 days, it will be closed automatically.

This is warning day 1 of 7.

Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it.

This comment was generated by an automated workflow.

## Summary - route aqua `format: 7z` archives through the existing archive extractor - detect `.7z` assets in the aqua registry mirror when `format` is omitted - add Windows e2e coverage using a small local aqua registry and the existing 7z fixture ## References - Addresses #10215 (`aqua:ImageMagick/ImageMagick` failed with `unsupported format: 7z`) - Unblocks #10214, the mise registry PR adding `aqua:ImageMagick/ImageMagick` for Windows support; that PR exposed that mise's aqua backend did not support 7z extraction - Aqua registry reference: aquaproj/aqua-registry#50281 added `ImageMagick/ImageMagick` to aqua, where aqua can install the Windows `.7z` release assets ## Testing - `cargo fmt --all -- --check` - `git diff --check` - Attempted `cargo test -p aqua-registry test_format_detects_7z_asset`, but local execution was blocked for an extended period by the shared Cargo build-directory lock from other worktrees; CI should cover this path - Windows Pester e2e not run locally on Linux  ## Summary by CodeRabbit * **New Features** * Added support for 7z archive format detection to recognize and handle 7z compressed archives * Implemented Windows-optimized extraction handling for 7z packages ensuring proper decompression and installation * **Tests** * Added end-to-end test suite validating 7z package installation workflow on Windows * Test coverage includes local registry configuration, tool installation, and execution verification

github-actions · 2026-06-06T00:25:51Z

This PR currently has failing checks. If this continues for 7 days, it will be closed automatically.

This is warning day 2 of 7.

Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it.

This comment was generated by an automated workflow.

iki · 2026-06-06T11:22:28Z

Closing as duplicate to #10118

registry: add imagemagick backend aqua:ImageMagick/ImageMagick for Wi…

424d528

…ndows support

greptile-apps Bot reviewed Jun 3, 2026

View reviewed changes

risu729 mentioned this pull request Jun 4, 2026

fix(aqua): extract 7z archives #10224

Merged

iki closed this Jun 6, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

registry: add imagemagick backend aqua:ImageMagick/ImageMagick for Windows support#10214

registry: add imagemagick backend aqua:ImageMagick/ImageMagick for Windows support#10214
iki wants to merge 1 commit into
jdx:mainfrom
iki:fix/fix-imagemagick-on-windows

iki commented Jun 3, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jun 3, 2026

Review skipped

Uh oh!

greptile-apps Bot commented Jun 3, 2026

Uh oh!

greptile-apps Bot Jun 3, 2026

Uh oh!

thernstig commented Jun 4, 2026

Uh oh!

github-actions Bot commented Jun 5, 2026

Uh oh!

github-actions Bot commented Jun 6, 2026

Uh oh!

iki commented Jun 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

iki commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jun 3, 2026

Review skipped

Uh oh!

greptile-apps Bot commented Jun 3, 2026

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

greptile-apps Bot Jun 3, 2026

Choose a reason for hiding this comment

Uh oh!

thernstig commented Jun 4, 2026

Uh oh!

github-actions Bot commented Jun 5, 2026

Uh oh!

github-actions Bot commented Jun 6, 2026

Uh oh!

iki commented Jun 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

iki commented Jun 3, 2026 •

edited

Loading