fix(aqua): extract 7z archives#10224
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR adds 7z archive format support to the Aqua package manager backend. Format detection recognizes Changes7z Archive Format Support
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Greptile SummaryThis PR adds 7z archive support to the aqua backend by routing
Confidence Score: 5/5Safe to merge — the change is narrowly scoped to the aqua 7z path, the Windows-only guard is expressed at compile time, and non-Windows behaviour is unchanged. All three changed files are small and self-contained. The cfg!(windows) guard correctly prevents the new code path from executing on non-Windows hosts, the format detection insertion doesn't conflict with any existing suffix, and the e2e test exercises the full install-and-execute flow against a real fixture. No files require special attention. Important Files Changed
Reviews (3): Last reviewed commit: "fix(aqua): guard 7z extraction by platfo..." | Re-trigger Greptile |
77c905e to
d788434
Compare
Summary
format: 7zarchives through the existing archive extractor.7zassets in the aqua registry mirror whenformatis omittedReferences
aqua:ImageMagick/ImageMagickfailed withunsupported format: 7z)aqua:ImageMagick/ImageMagickfor Windows support; that PR exposed that mise's aqua backend did not support 7z extractionImageMagick/ImageMagickto aqua, where aqua can install the Windows.7zrelease assetsTesting
cargo fmt --all -- --checkgit diff --checkcargo test -p aqua-registry test_format_detects_7z_asset, but local execution was blocked for an extended period by the shared Cargo build-directory lock from other worktrees; CI should cover this pathSummary by CodeRabbit
New Features
Tests