fix(ubi): filter versions with tag_regex before trimming v prefixes#6421
Merged
fix(ubi): filter versions with tag_regex before trimming v prefixes#6421
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the order of operations in the UBI backend by filtering versions with tag_regex before trimming 'v' prefixes. This ensures that version filtering is performed on the original tag names before any string manipulation occurs.
- Moved the tag_regex filtering logic to execute before trimming 'v' prefixes
- Added debug logging to show which versions are filtered by tag_regex
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/backend/ubi.rs
Outdated
Comment on lines
+91
to
+93
| let result = re.is_match(v); | ||
| debug!("filter {v} by tag_regex {re}: {result}"); | ||
| result |
There was a problem hiding this comment.
The temporary result variable is unnecessary. Consider returning re.is_match(v) directly and moving the debug logging to a separate line for clarity.
Suggested change
| let result = re.is_match(v); | |
| debug!("filter {v} by tag_regex {re}: {result}"); | |
| result | |
| debug!("filter {v} by tag_regex {re}: {}", re.is_match(v)); | |
| re.is_match(v) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows filtering tags with
vprefixes.