registry: revert opam/k3kcli backends to ubi#6406
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the opam backend from GitHub releases to UBI (Universal Binary Installer) and adds version testing functionality.
- Reverts opam backend from
github:ocaml/opamtoubi:ocaml/opam - Adds version test command to verify opam installation
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
risu729
changed the title
Owner
|
Seems like we could support non-archive binaires, no? I might have a look at this soon. Is the tool supposed to be failing in this PR? |
Contributor
Author
Oh are we not supporting them in GitHub backend? If so we can just add support for it.
|
Comment out test commands for k3kcli tool.
jdx
pushed a commit
that referenced
this pull request
Sep 28, 2025
~~Also reverts #6406 --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6402.
Neither works with the GitHub backend because the releases have archives, but we need to download non-archive files.
https://github.com/ocaml/opam/releases/tag/2.4.1
https://github.com/rancher/k3k/releases/tag/v0.3.4
We should fix it, but I don't have a good idea how to fix it.
Maybe we can only exclude small non-archive files (text files) when archive files exist, but I think this also causes some bugs.