Revert "docs: Update install instructions for nushell"#5983
Merged
Conversation
This reverts commit 51af3e8.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts a previous change to the Nushell installation instructions for mise. The revert restores the original method of appending to both env.nu and config.nu files instead of using the autoload directory approach.
- Reverts installation method from autoload directory to manual file appending
- Restores multi-step installation process for Nushell users
- Changes back to using separate
env.nuandconfig.nuconfiguration steps
| ' | ||
| let mise_path = $nu.default-config-dir | path join mise.nu | ||
| ^mise activate nu | save $mise_path --force | ||
| ' | save $nu.env-path --append |
There was a problem hiding this comment.
The single quote at the beginning of line 301 appears to be orphaned and would cause a syntax error. This line should either be removed or properly paired with a closing quote.
Suggested change
| ' | save $nu.env-path --append | |
| """ | |
| let mise_path = $nu.default-config-dir | path join mise.nu | |
| ^mise activate nu | save $mise_path --force | |
| """ | save $nu.env-path --append |
| ' | ||
| let mise_path = $nu.default-config-dir | path join mise.nu | ||
| ^mise activate nu | save $mise_path --force | ||
| ' | save $nu.env-path --append |
There was a problem hiding this comment.
This line appears to close a multi-line string that was started incorrectly on line 301. The string construction is malformed and would not execute properly in Nushell.
Suggested change
| ' | save $nu.env-path --append | |
| ''' | |
| let mise_path = $nu.default-config-dir | path join mise.nu | |
| ^mise activate nu | save $mise_path --force | |
| ''' | save $nu.env-path --append |
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.8.8 x -- echo |
19.0 ± 0.3 | 18.4 | 22.4 | 1.00 |
mise x -- echo |
19.4 ± 0.3 | 18.7 | 21.8 | 1.02 ± 0.02 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.8.8 env |
18.5 ± 0.3 | 18.0 | 19.7 | 1.00 |
mise env |
18.9 ± 0.6 | 18.1 | 26.2 | 1.02 ± 0.04 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.8.8 hook-env |
18.2 ± 0.3 | 17.5 | 22.2 | 1.00 |
mise hook-env |
18.5 ± 0.4 | 17.6 | 22.1 | 1.02 ± 0.03 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.8.8 ls |
17.0 ± 0.2 | 16.5 | 18.1 | 1.00 |
mise ls |
17.4 ± 0.3 | 16.7 | 18.9 | 1.02 ± 0.02 |
xtasks/test/perf
| Command | mise-2025.8.8 | mise | Variance |
|---|---|---|---|
| install (cached) | 193ms | ✅ 130ms | +48% |
| ls (cached) | 81ms | 82ms | -1% |
| bin-paths (cached) | 66ms | 66ms | +0% |
| task-ls (cached) | 491ms | 481ms | +2% |
✅ Performance improvement: install cached is 48%
jdx
pushed a commit
that referenced
this pull request
Aug 13, 2025
### 📦 Registry - add vfox-yarn as primary yarn backend by [@jdx](https://github.com/jdx) in [#5982](#5982) - add missing description field for a lot of tools by [@jylenhof](https://github.com/jylenhof) in [#5966](#5966) - rename benthos to redpanda-connect by [@risu729](https://github.com/risu729) in [#5984](#5984) - rename coq to rocq by [@risu729](https://github.com/risu729) in [#5985](#5985) ### 🚀 Features - **(timeout)** show duration, URL, and config hint on timeouts; increase fetch timeout default to 10s by [@jdx](https://github.com/jdx) in [#5991](#5991) ### 🐛 Bug Fixes - **(aqua)** add executable permissions for zip-extracted binaries by [@itochan](https://github.com/itochan) in [#5998](#5998) - **(core)** auto-repair corrupted pyenv cache by recloning on update failure by [@jdx](https://github.com/jdx) in [#6003](#6003) - duplicate versions and validation in `mise tool` by [@jdx](https://github.com/jdx) in [#6001](#6001) ### 📚 Documentation - **(tools)** document per-tool postinstall option in [tools] by [@jdx](https://github.com/jdx) in [#5993](#5993) - Update install instructions for nushell by [@Joniator](https://github.com/Joniator) in [#5981](#5981) - README.md typo by [@jdx](https://github.com/jdx) in [#5990](#5990) ###◀️ Revert - Revert "docs: Update install instructions for nushell" by [@jdx](https://github.com/jdx) in [#5983](#5983) - Revert "fix(aqua): add executable permissions for zip-extracted binaries" by [@jdx](https://github.com/jdx) in [#6004](#6004) ### 📦️ Dependency Updates - update taiki-e/install-action digest to 2c73a74 by [@renovate[bot]](https://github.com/renovate[bot]) in [#5962](#5962) - update docker/metadata-action digest to c1e5197 by [@renovate[bot]](https://github.com/renovate[bot]) in [#5961](#5961) - update docker/login-action digest to 184bdaa by [@renovate[bot]](https://github.com/renovate[bot]) in [#5958](#5958) ### Chore - cargo up by [@jdx](https://github.com/jdx) in [#5992](#5992) ### New Contributors - @Joniator made their first contribution in [#5981](#5981) - @jylenhof made their first contribution in [#5966](#5966)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #5981
reverted until we can sort out the best way to handle this