Skip to content

chore(ci): accept @ in regular expressions for new registry PR titles#5969

Merged
jdx merged 1 commit into
jdx:mainfrom
mst-mkt:fix/registry_comment_action
Aug 10, 2025
Merged

chore(ci): accept @ in regular expressions for new registry PR titles#5969
jdx merged 1 commit into
jdx:mainfrom
mst-mkt:fix/registry_comment_action

Conversation

@mst-mkt

@mst-mkt mst-mkt commented Aug 10, 2025

Copy link
Copy Markdown
Contributor

description

Currently, PRs that add new registries are checked by github actions for their titles, but the current check fails because npm's scoped modules contain @ (like npm:@anthropic-ai/claude-code).

This PR adds @ to the regex pattern to fix the validation.

You can see this failed action in #5967, which I created
(this PR has been closed as it was unnecessary).

Copilot AI review requested due to automatic review settings August 10, 2025 11:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a GitHub Actions validation issue for new registry PRs by updating the title format regex to support npm scoped modules that contain the @ character.

  • Adds @ character to the regex pattern that validates PR titles for new registry additions
  • Enables proper validation of npm scoped modules (e.g., @scope/package-name) in registry PR titles

@jdx jdx merged commit f3458e9 into jdx:main Aug 10, 2025
19 checks passed
jdx pushed a commit that referenced this pull request Aug 11, 2025
### 📦 Registry

- add bob
([aqua:MordechaiHadad/bob](https://github.com/MordechaiHadad/bob)) by
[@TyceHerrman](https://github.com/TyceHerrman) in
[#5914](#5914)
- support usage on FreeBSD by [@risu729](https://github.com/risu729) in
[#5973](#5973)
- filter out installer for podman by
[@risu729](https://github.com/risu729) in
[#5974](#5974)
- use pipx aqua backend by [@itochan](https://github.com/itochan) in
[#5971](#5971)

### 📚 Documentation

- add documentation for os field in tool configuration by
[@jdx](https://github.com/jdx) in
[#5947](#5947)

### Chore

- **(ci)** accept @ in regular expressions for new registry PR titles by
[@mst-mkt](https://github.com/mst-mkt) in
[#5969](#5969)
- fix registry test filter by [@risu729](https://github.com/risu729) in
[#5942](#5942)
- fix registry test by [@risu729](https://github.com/risu729) in
[#5953](#5953)

### New Contributors

- @itochan made their first contribution in
[#5971](#5971)
- @mst-mkt made their first contribution in
[#5969](#5969)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants