chore: fix registry test filter#5942
Conversation
risu729
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a registry test filter workflow by addressing a mise exec error that occurred when using redirects or calling mise exec multiple times. The fix involves pre-installing tools to avoid the problematic mise exec behavior.
- Pre-install required tools (
jdandyj) before executing commands - Add explicit shell configuration with pipefail option
- Add debug output to display changed tools
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| with: | ||
| install_args: jd yj | ||
| - id: diff | ||
| shell: bash # -eo pipefail |
There was a problem hiding this comment.
Bug: Pipeline Fails to Exit Early on Errors
The diff step's shell is set to bash, but the intended -eo pipefail flags (indicated by a comment) are missing. This prevents the step from failing fast on pipeline errors, which the PR description states was the exact issue this change aimed to fix.
There was a problem hiding this comment.
Yes, but it's not necessary.
There was a problem hiding this comment.
Sorry, I didn't describe it well.
shell: bash uses bash --noprofile --norc -eo pipefail {0} instead of bash -e {0}.
https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#jobsjob_idstepsshell
| <(mise x yj -- yj -t < registry.toml) \ | ||
| | jq -r '[.tools // {} | keys[]] | join(" ")' \ | ||
| ) | ||
| echo $changed_tools |
There was a problem hiding this comment.
Bug: Debug Code Left in Workflow
The echo $changed_tools line in the workflow is debug code that was accidentally left in. It serves no functional purpose and adds unnecessary output to the CI logs.
There was a problem hiding this comment.
I left it for debugging purposes in the future. Should I remove it?
### 📦 Registry - add bob ([aqua:MordechaiHadad/bob](https://github.com/MordechaiHadad/bob)) by [@TyceHerrman](https://github.com/TyceHerrman) in [#5914](#5914) - support usage on FreeBSD by [@risu729](https://github.com/risu729) in [#5973](#5973) - filter out installer for podman by [@risu729](https://github.com/risu729) in [#5974](#5974) - use pipx aqua backend by [@itochan](https://github.com/itochan) in [#5971](#5971) ### 📚 Documentation - add documentation for os field in tool configuration by [@jdx](https://github.com/jdx) in [#5947](#5947) ### Chore - **(ci)** accept @ in regular expressions for new registry PR titles by [@mst-mkt](https://github.com/mst-mkt) in [#5969](#5969) - fix registry test filter by [@risu729](https://github.com/risu729) in [#5942](#5942) - fix registry test by [@risu729](https://github.com/risu729) in [#5953](#5953) ### New Contributors - @itochan made their first contribution in [#5971](#5971) - @mst-mkt made their first contribution in [#5969](#5969)
Resolves #5914 (comment).
It failed with a mise error, and I didn't set
pipefail, so it continued with an error.The mise error seems to occur when
mise execis called with a<redirect, ormise execis called twice in a row.I don't have any ideas what's happening and I don't think it's a common problem, so I fix the workflow by installing the tools before
mise exec, which works fine as a workaround.action log