fix: prefer offline when executing shims#5195
Merged
Merged
Conversation
jdx
force-pushed
the
prefer-offline
branch
2 times, most recently
from
5d15b35 to
26f77bd
Compare
e2e/perf/test_many_tasks
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.5.13 x -- echo |
52.1 ± 0.9 | 49.8 | 57.6 | 1.11 ± 0.03 |
mise x -- echo |
47.0 ± 1.1 | 45.8 | 61.0 | 1.00 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.5.13 env |
51.7 ± 1.7 | 48.9 | 82.2 | 1.12 ± 0.05 |
mise env |
46.2 ± 1.2 | 44.8 | 67.6 | 1.00 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.5.13 hook-env |
51.6 ± 1.3 | 49.1 | 64.0 | 1.12 ± 0.03 |
mise hook-env |
45.9 ± 0.4 | 44.5 | 47.4 | 1.00 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.5.13 ls |
58.6 ± 0.6 | 57.0 | 63.4 | 1.02 ± 0.01 |
mise ls |
57.4 ± 0.4 | 56.4 | 59.8 | 1.00 |
jdx
force-pushed
the
prefer-offline
branch
2 times, most recently
from
3431ead to
7be8e8c
Compare
jdx
force-pushed
the
prefer-offline
branch
2 times, most recently
from
b1f1a0d to
c700ab4
Compare
jdx
pushed a commit
that referenced
this pull request
May 26, 2025
### 🐛 Bug Fixes - installing tools with postinstall hooks fails by [@roele](https://github.com/roele) in [#5191](#5191) - prefer offline when executing shims by [@jdx](https://github.com/jdx) in [#5195](#5195) - multi-line task output is shown in bold by [@roele](https://github.com/roele) in [#5197](#5197) ### ⚡ Performance - improve tool loading performance in async code by [@jdx](https://github.com/jdx) in [#5198](#5198)
jdx
pushed a commit
that referenced
this pull request
Jul 11, 2025
Aligns the version resolution logic (from canonicalised version to GitHub tag) in `list_bin_paths` with the one in `install_version_`. I think this doesn't change the behaviour for offline introduced in #5195. > TODO: instead of caching it would probably be better to create this as part of installation Regarding this TODO, I agreed with it and tried to work on it, but was not sure how to. I'd like to ask for some advice. I thought of storing `bin_paths.msgpack.z` in the installation path, `tv.install_path()`, while the installation, and reading it when `list_bin_paths` is called. Not to break the installations with old versions, or just in case `bin_paths.msgpack.z` is removed somehow, I think we need to fall back to the current implementation if it's not found. However, then it would be the same as the current implementation, except that `list_bin_paths` is called in the installation and the cache is created.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.