[tmkx]

Non-cached tool-stub exec rebuilt PATH from pristine env, which dropped project _.path dirs from __MISE_DIFF and broke nested LookPath of sibling stubs. Rebuilding from the caller PATH could also let an outer task's install dirs shadow the stub-selected version.

Keep toolset.env_with_path (already includes _.path and filters outer install dirs) and only prepend backend dependency bins (#7777).

Summary by CodeRabbit

Summary by CodeRabbit

• Bug Fixes
  • Fixed tool execution so caller-provided PATH entries are preserved, including paths configured through environment settings.
  • Improved nested and sibling tool discovery when using non-cached tool stubs.
  • Ensured the tool version selected by a stub takes precedence over versions provided by an outer task.
• Tests
  • Added end-to-end coverage verifying sibling commands remain discoverable and the selected tool version is used during tool-stub execution.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: f92d9a8c-9998-470d-8c78-1cfdfec8b8b0

📥 Commits

Reviewing files that changed from the base of the PR and between bc0ba12 and a8a3007.

📒 Files selected for processing (1)

• src/cli/tool_stub.rs

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

Tool-stub execution now uses env_with_path as the PATH base and prepends backend dependency paths when present. End-to-end tests cover sibling lookup and stub-selected version precedence during non-cached execution.

Changes

Tool-stub PATH preservation

Layer / File(s)	Summary
Preserve PATH and validate tool resolution src/cli/tool_stub.rs, e2e/cli/test_tool_stub_preserves_caller_path_slow	Tool-stub execution preserves the PATH from env_with_path and prepends backend dependency paths. The tests verify sibling lookup and selection of the stub-provided version over an outer task version.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to a8a30

This change preserves project PATH entries while avoiding unintended outer task install directories and adding only backend dependency bins; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: jdx, risu729

Poem

A rabbit checks the PATH,
Stubs select the tool,
Sibling commands stay in reach,
Outer versions yield,
Cache-cleared runs confirm.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: preserving env_with_path instead of rebuilding PATH during tool-stub execution.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Greptile Summary

The PR preserves the toolset-generated environment during non-cached tool-stub execution while prepending required backend dependency bins.

• Retains project-configured _.path entries and filters inherited mise installation paths.
• Adds slow end-to-end coverage for sibling discovery and stub-selected version precedence.
• Corrects the new test file mode to the repository’s non-executable convention.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; the inherited-tool shadowing issue is addressed by retaining the filtered toolset environment, and the executable-mode issue is fixed.

Important Files Changed

Filename	Overview
src/cli/tool_stub.rs	Reuses env_with_path, then prepends backend dependency bins without restoring the inherited outer tool paths implicated by the prior finding.
e2e/cli/test_tool_stub_preserves_caller_path_slow	Adds regression coverage for both PATH preservation and version precedence, with the test now committed as mode 100644.

_{Reviews (5): Last reviewed commit: "fix(tool-stub): keep env_with_path inste..." | Re-trigger Greptile}

[tmkx]

mise/e2e-win/exec_inactive_tool.Tests.ps1

Lines 48 to 51 in 23f8607

	It 'suggests a command that works' {
	$out = (& $script:miseExe exec usage -- usage --version 2>&1 | Out-String)
	$out | Should -Match "usage-cli"
	}

the output of usage --version is changed in recent releases.