fix(schema): allow registry backend platform selectors#10358
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR expands the mise-registry-tool JSON schema to support broader platform/architecture validation for backend definitions, introducing a ChangesRegistry Tool Platform Schema & E2E Validation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Greptile SummaryThis PR widens the
Confidence Score: 5/5Safe to merge — the changes are additive schema relaxations with no runtime code path touched. Both changed files are pure schema and test script. The No files require special attention. Important Files Changed
Reviews (2): Last reviewed commit: "fix(schema): allow registry backend plat..." | Re-trigger Greptile |
1afc0f7 to
5199a4c
Compare
Summary
platformsentries to use supported OS, architecture, or normalizedos-archselectorswindows-x64and invalid unsupported formsSupported registry platform formats
For
backends[].platforms, the schema accepts:freebsd,linux,macos,openbsd,windowsx64,arm64,x86,loongarch64,riscv64<os>-<arch>, for examplewindows-x64,linux-arm64,macos-x64For
backends.options.platforms.<key>, the schema accepts the unqualified OS/arch keys the option lookup helper probes:linux,macos,darwin,windowsx64,amd64,x86_64,arm64,aarch64,x86,loongarch64,riscv64linux-x64,linux-amd64,macos-arm64,darwin-aarch64,windows-x64Qualified keys such as
linux-x64-muslare not included because the current backend option lookup does not read them.windows-amd64is also left invalid as abackends[].platformsselector because mise normalizes that platform key towindows-x64.Context
Addresses the schema issue reported in discussion #10296.
Validation
jq empty schema/mise-registry-tool.jsonmise run test:e2e config/test_schema_tombiSummary by CodeRabbit
New Features
Tests