Skip to content

registry: scope imagemagick aqua backend to windows-x64#10400

Merged
jdx merged 2 commits into
jdx:mainfrom
risu729:registry/imagemagick-windows-x64
Jun 13, 2026
Merged

registry: scope imagemagick aqua backend to windows-x64#10400
jdx merged 2 commits into
jdx:mainfrom
risu729:registry/imagemagick-windows-x64

Conversation

@risu729

@risu729 risu729 commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Scope the aqua ImageMagick backend to windows-x64 instead of the broader windows platform selector.
  • Uses mise's normalized os-arch registry platform key (windows-x64), not windows-amd64, which the registry schema rejects.

Follow-up to #10296.

Test plan

  • CI passes (registry schema validation)

Made with Cursor

Summary by CodeRabbit

  • Chores
    • Updated ImageMagick backend platform configuration for Windows systems to specify 64-bit compatibility.

@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 52b84d65-ae74-4fb5-9cb7-e15331ddfef9

📥 Commits

Reviewing files that changed from the base of the PR and between e532297 and eab0667.

📒 Files selected for processing (1)
  • registry/imagemagick.toml

📝 Walkthrough

Walkthrough

The ImageMagick backend configuration in the registry was updated to use a more specific Windows platform identifier. The platforms entry changed from the generic "windows" label to "windows-x64", aligning with standardized platform naming conventions used across the registry.

Changes

ImageMagick Platform Identifier Update

Layer / File(s) Summary
Windows platform identifier normalization
registry/imagemagick.toml
The ImageMagick backend's Windows platform identifier in the platforms list was updated from "windows" to "windows-x64" for consistency with standardized platform naming.

Possibly Related PRs

  • jdx/mise#10358: Normalizes platform selector validation to accept windows-x64 and other architecture-specific identifiers, providing the schema foundation for this registry update.
  • jdx/mise#10118: Earlier PR that introduced the ImageMagick backend with platform configurations; this PR refines the Windows platform identifier to use the standardized naming convention.

Poem

🐰 From generic to precise, the Windows identifier now shines—
windows-x64 on the line, architecture crystalline!
Registry clean, platform-specific, normalized and true,
A humble one-liner makes the backend brand new! ✨


🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title states the change is to scope 'imagemagick aqua' backend, but the actual change is to the 'imagemagick' backend's windows platform identifier. The mention of 'aqua' appears to be inaccurate or misleading. Revise the title to accurately reflect the change: 'registry: scope imagemagick backend to windows-x64' or similar, removing the misleading 'aqua' reference.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps

greptile-apps Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR narrows the aqua ImageMagick backend's platform selector from the broad "windows" key to the more precise "windows-x64", restricting the aqua backend to Windows x64 machines only. The change is consistent with how other registry entries (e.g., claude.toml, flutter.toml, flyway.toml) scope Windows-specific aqua/http backends and aligns with mise's normalized os-arch platform key format.

  • Changes one line in registry/imagemagick.toml: "windows""windows-x64" in the aqua backend's platforms array.
  • Other backends (conda:imagemagick, asdf:mise-plugins/mise-imagemagick) remain unchanged and continue to serve all platforms.

Confidence Score: 5/5

Minimal, targeted change that correctly scopes the aqua ImageMagick backend to Windows x64 only, matching the pattern used across other registry entries.

Single-line config change with no logic involved. The windows-x64 key is the correct normalized form used consistently throughout the registry, and fallback backends remain in place for other platforms.

No files require special attention.

Important Files Changed

Filename Overview
registry/imagemagick.toml Narrows the aqua backend platform selector from "windows" (all Windows architectures) to "windows-x64", matching only x64 Windows — consistent with how other registry entries scope Windows builds.

Reviews (2): Last reviewed commit: "Merge branch 'main' into registry/imagem..." | Re-trigger Greptile

@risu729 risu729 marked this pull request as ready for review June 13, 2026 15:14
@jdx jdx merged commit ba3f67e into jdx:main Jun 13, 2026
34 checks passed
@risu729 risu729 deleted the registry/imagemagick-windows-x64 branch June 13, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants