Correct property names and improve scope-names #54
Conversation
|
Thanks, I'll check it out. |
| '0': | ||
| 'name': 'support.punctuation.blade' | ||
| '1': | ||
| 'name': 'source.php' |
There was a problem hiding this comment.
Leave these kind captures in, this is a hack required for text editors for properly detect inner scope when the contents of the block is 0 width, like {{|}} where | is cursor.
There was a problem hiding this comment.
As a way to trigger PHP-specific snippets and commands, I assume?
Why not move the source.php scope to the containing block's name property, then...?
There was a problem hiding this comment.
I've restored the capturing groups, but you should perhaps consider adding a comment to elaborate on why they're necessary. Future contributors may also misinterpret those groups as a mistake.
| 'name': 'support.punctuation.blade' | ||
| '1': | ||
| 'name': 'source.php' | ||
| 'name': 'punctuation.section.begin.embedded.blade' |
There was a problem hiding this comment.
Move .begin and .end after .embedded like you did with comment.
|
@Ingramz There's an emergency release of Linguist due to be cut pretty soon, and it'd be nice to get these highlighting issues fixed on the site instead of wait a few more weeks. :) |
|
@Alhadis alright. It'll have to wait till I am done with my work commitments for the day, though. |
|
@Alhadis I'm sorry it didn't make the cut (pun intended). But here's my offer regarding scope names: Bold marks differences. Let me know what you think. I think it's a slightly better compromise between properly defined names and not looking like crap, but definitely not perfect. I will probably start splitting built-in directives into smaller groups by their function, eg control keywords and other keywords, but let that be for now. Is there any way to test this configuration against linguist ahead of time? |
Well, there's a webapp called Lightshow which will give a general impression, but its highlighting palette is outdated and the app itself is buggy. Should be enough though. |
|
At least with lightshow the echo mustaches look pretty now 😸 |
|
Well, at the end of the day, that's all that matters, I guess. :) Pretty moustaches an' shit. |
| 'contentName': 'source.php' | ||
| 'name': 'meta.embedded.blade' | ||
| 'name': 'meta.embedded.keyword.blade' |
There was a problem hiding this comment.
should be meta.embedded.block.blade
|
Sweet. Expect a release very soon™. |
|
Ace, now people will shaddap at Linguist. 👍 |
|
Aitäh! |
Fixes #48 and fixes #53.