Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope names are inconsistent #48

Closed
jbrooksuk opened this issue Jul 15, 2016 · 2 comments · Fixed by #54
Closed

Scope names are inconsistent #48

jbrooksuk opened this issue Jul 15, 2016 · 2 comments · Fixed by #54

Comments

@jbrooksuk
Copy link

GitHub now supports highlighting of Blade files (thanks to this package 🎉) however, it's unable to highlight the @end scopes due to inconsistent names.

github-linguist/linguist#3119 (comment)

As @Alhadis suggested, the repo needs to follow the guidelines on naming conventions.

@Alhadis
Copy link
Contributor

Alhadis commented Jul 15, 2016

To point out the pertinent part:

the meta scope is generally used to markup larger parts of the document. For example the entire line which declares a function would be meta.function and the subsets would be storage.type, entity.name.function, variable.parameter etc. and only the latter would be styled.

This package is assigning meta.embedded.keyword.blade to @endif, which is basically combining two elements that're expected to be separate: meta and keyword.

@Ingramz
Copy link
Collaborator

Ingramz commented Jul 15, 2016

It has been an issue for a long time, so it doesn't come to me as a surprise.

Here is where you need to look at https://github.com/jawee/language-blade/blob/master/grammars/blade.cson#L12-L120

Submit a pull request if you think you have an idea how to solve this.

Ingramz pushed a commit that referenced this issue Sep 15, 2016
* Correct property names and improve scope-names

Fixes #48 and fixes #53.

* Restore capturing groups removed in 8daf4e9

* Apply style corrections

* Apply recommended scope-name changes

* Fix incorrect scope name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants