Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub syntax #53

Closed
RonMelkhior opened this issue Sep 4, 2016 · 0 comments · Fixed by #54
Closed

GitHub syntax #53

RonMelkhior opened this issue Sep 4, 2016 · 0 comments · Fixed by #54

Comments

@RonMelkhior
Copy link

Hi,

Got forwarded from the GitHub linguist repository (github-linguist/linguist#3185), currently, GitHub does not highlight end calls, such as @endif or @endforeach.

Example:

@if ($errors->first())
    <div class="row">
        <div class="sixteen wide widescreen sixteen wide computer sixteen wide tablet sixteen wide mobile column">
            <div class="ui negative message">
                <div class="header">
                    There's been an error.
                </div>
                <ul class="list">
                    @foreach ($errors->all() as $error)
                        <li>{{ $error }}</li>
                    @endforeach
                </ul>
            </div>
        </div>
    </div>
@endif
Ingramz pushed a commit that referenced this issue Sep 15, 2016
* Correct property names and improve scope-names

Fixes #48 and fixes #53.

* Restore capturing groups removed in 8daf4e9

* Apply style corrections

* Apply recommended scope-name changes

* Fix incorrect scope name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant