Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prettier to the latest version 🚀 #632

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Mar 21, 2020


☝️ Important announcement: Greenkeeper will be saying goodbye 👋 and passing the torch to Snyk on June 3rd, 2020! Find out how to migrate to Snyk and more at greenkeeper.io


The dependency prettier was updated from 1.19.1 to 2.0.0.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Publisher: thorn0
License: MIT

Find out more about this release.


FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

greenkeeper bot added a commit that referenced this pull request Mar 21, 2020
@greenkeeper

This comment has been minimized.

@agilgur5
Copy link
Collaborator

Release Notes: https://prettier.io/blog/2020/03/21/2.0.0.html

Yea this is pretty breaking, definitely gonna hold out on this for a bit to go out when things are more stable in TSDX, don't wanna make too many breaking changes back-to-back, particularly when not necessary.

Even the internal lint gets a bunch of errors on this codebase, would make for lots of big diffs in various codebases 😕

Weird that the lint test only fails on Windows and not on Ubuntu or macOS... wonder if it might have to do with the LF line ending change in the update 🤔

greenkeeper bot added a commit that referenced this pull request Mar 23, 2020
@greenkeeper

This comment has been minimized.

@greenkeeper

This comment has been minimized.

greenkeeper bot added a commit that referenced this pull request Apr 5, 2020
greenkeeper bot added a commit that referenced this pull request Apr 6, 2020
@greenkeeper

This comment has been minimized.

@greenkeeper

This comment has been minimized.

@kachkaev
Copy link

kachkaev commented Sep 14, 2020

Upgrading prettier to v2 would be great indeed. Using tsdx in a monorepo and end up with two copies of Prettier because of that. At the time of writing, the latest version of Prettier is v2.1.1

JackCA added a commit to astraldigital/passport-magic-login that referenced this pull request Jan 16, 2021
- prettier 1.* does not support typescript 3.8's type imports. tsdx has
  not upgraded to prettier 2.* yet so we cannot use type imports yet.
  See jaredpalmer/tsdx#632 and prettier/prettier#7263
@vltansky
Copy link

vltansky commented Feb 1, 2021

Getting

error  Parsing error: '=' expected  prettier/prettier

cause of

import type { Configuration, RuleSetLoader, RuleSetUseItem } from 'webpack';

updating prettier fixed it for me.

cheapsteak added a commit to cheapsteak/local-memory-storage that referenced this pull request Feb 7, 2022
tsdx uses prettier 1.x, which doen't recognize private fields (jaredpalmer/tsdx#657)

these custom dependency versions can be removed once tsdx updates to use prettier 2.x
jaredpalmer/tsdx#632 (expected to be tsdx v 0.16)

Signed-off-by: Chang Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants